Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[network] Possible performance improvement for performArpPing #16262

Open
lsiepel opened this issue Jan 12, 2024 · 3 comments
Open

[network] Possible performance improvement for performArpPing #16262

lsiepel opened this issue Jan 12, 2024 · 3 comments
Assignees
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@lsiepel
Copy link
Contributor

lsiepel commented Jan 12, 2024

Another issue with the current iOS wake up implementation is that it is part of performArpPing which is executed for every network interface. So it is executed many times if you don't restrict the number of network interfaces (#16145).

Originally posted by @wborn in #9575 (comment)

@lsiepel lsiepel self-assigned this Jan 12, 2024
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Jan 12, 2024
@wborn
Copy link
Member

wborn commented Jan 12, 2024

If iOS wake up is configured it could be put into its own CompletableFuture and after it completes the arping commands could be exectued, e.g. using thenRunAsync

@lsiepel
Copy link
Contributor Author

lsiepel commented Sep 15, 2024

Was briefly looking into this. I doubt there will be any benefit.

The wakeUpIOS is strictly tied to the performArpPing, e.g. it is a pre-requisite for the following nativeArpPing.

As this check is conditionally if (iosDevice) and the interfaces can be restricted. I have a hard time to see where there are optimisations left. wdyt?

@wborn
Copy link
Member

wborn commented Oct 3, 2024

IIRC it would optimize network traffic when using the default configuration and having lots of (Docker) interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

No branches or pull requests

2 participants