Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wart remover and ScalaJS play nicely #59

Open
outkaj opened this issue May 1, 2019 · 1 comment
Open

Make wart remover and ScalaJS play nicely #59

outkaj opened this issue May 1, 2019 · 1 comment

Comments

@outkaj
Copy link
Contributor

outkaj commented May 1, 2019

Wart remover and Scala JS don't play well together - wart remover thinks JsExport, etc are signs of an error. There used to be a wart remover plugin specifically for ScalaJS, but it seems deprecated. At some point we should still enable Wart Remover for the project (we may have to make a custom ruleset disabling some of their basic rules).

@adridadou
Copy link
Member

Let's push that for later. It's not very important for now because openlaw-client doesn't have that much code anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants