Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosting / security work #75

Open
edjw opened this issue Nov 15, 2019 · 1 comment
Open

Hosting / security work #75

edjw opened this issue Nov 15, 2019 · 1 comment
Assignees
Labels
important feature A request for a new feature

Comments

@edjw
Copy link

edjw commented Nov 15, 2019

The site is currently hosted on Digital Ocean. We need to decide if we keep it there or put it on Bytemark.

Then point the right domain at the PESIA

Some security testing is required. The install.php file shouldn’t be on the public website for example. Turn off public registration of admin users

Dan thinks cross-site scripting is a concern and I agree.

@edjw edjw added the important feature A request for a new feature label Nov 15, 2019
@edjw edjw added this to the MVP milestone Nov 15, 2019
@javierruizorg javierruizorg removed this from the MVP milestone Nov 15, 2019
@dantheta
Copy link
Collaborator

The best fix for the XSS issues I can think of is switching the views (page templates) from raw PHP to a templating language like twig. This automatically tracks the origin of each of the variables (such as query string parameter or database entry) and renders the values safely. This wouldn't actually take that long, and would also make the view templates easier to read and work on in the future (which would be useful when applying the designer's styling).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important feature A request for a new feature
Projects
None yet
Development

No branches or pull requests

3 participants