Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-Side Request Forgery risk #9149

Open
Tracked by #9147
zhongnansu opened this issue Jan 6, 2025 · 2 comments
Open
Tracked by #9147

Server-Side Request Forgery risk #9149

zhongnansu opened this issue Jan 6, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request multiple datasource multiple datasource project v2.19.0

Comments

@zhongnansu
Copy link
Member

zhongnansu commented Jan 6, 2025

The “Test Connection” functionality of the data sources page reaches out to the saved data source endpoint to make sure connection is healthy. It is possible to modify the endpoint for this resource and force the application server to attempt to access a different location.

@zhongnansu zhongnansu added enhancement New feature or request multiple datasource multiple datasource project v2.19.0 labels Jan 6, 2025
@zhongnansu
Copy link
Member Author

set to v2.19.0 for now, but may not have enough bandwidth to fix it

@zhongnansu zhongnansu self-assigned this Jan 9, 2025
@zhongnansu
Copy link
Member Author

Writing down the solution here for reference

  1. Need to utilize managedBy config to deny "endpoint" param in test connection API, or throw error in the API handler
  2. to achieve 1, we need to expose managedBy as an plugin capability (dsm plugin) to let other plugin (data source plugin) to consume

@zhongnansu zhongnansu assigned zhongnansu and unassigned zhongnansu Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request multiple datasource multiple datasource project v2.19.0
Projects
None yet
Development

No branches or pull requests

1 participant