Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query parameters in "http.url" tag #268

Open
pauqilaz opened this issue Apr 27, 2022 · 3 comments
Open

Query parameters in "http.url" tag #268

pauqilaz opened this issue Apr 27, 2022 · 3 comments
Labels

Comments

@pauqilaz
Copy link

The http.url span tag is currrently set to "$scheme://$http_host$request_uri" which includes the query parameters.
Since these are more likely to contain sensitive information, would it make sense to remove the query parameters from the tag ?

Thanks!

@miry
Copy link
Collaborator

miry commented Apr 27, 2022

@pauqilaz You are right. I would advice to obfuscate/drop tag in opentelemetry collector side.
Another suggestion to move sensitive information from query to headers, just because of this.
The url is mostly likely be logged or shared in other places.

@pauqilaz
Copy link
Author

pauqilaz commented Apr 28, 2022

Removing it altogether is one possibility, since it can still be re-added as an optional tag. Alternatively, replacing it with "$scheme://$http_host$uri" should already remove the query parameters.

@miry
Copy link
Collaborator

miry commented Apr 28, 2022

More about semantic convention of http.url in https://opentracing.io/specification/conventions/

http.url string URL of the request being handled in this segment of the trace, in standard URI format. E.g., "https://domain.net/path/to?resource=here"

@miry miry added the question label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants