Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random (critical) stuff to fix #3

Open
25 of 27 tasks
ick003 opened this issue May 4, 2022 · 1 comment
Open
25 of 27 tasks

Random (critical) stuff to fix #3

ick003 opened this issue May 4, 2022 · 1 comment

Comments

@ick003
Copy link
Member

ick003 commented May 4, 2022

  • Fix the reception / serve evaluation pairing
  • Add serving ace
  • dig player suggestion needs to know whether the libero is on court or not (assume not when middle is serving)
  • save files either via the downloadButton (i.e. save through the browser) or direct save to local file system, if the user is serving the app direct from their own R session
  • auto-save file after each rally
  • the rp2 function needs to rationalize multiple >Lup codes
  • use the libero info from the lineup, not from the file metadata section, otherwise libero-per-set will never be handled correctly
  • show the libero(s) on the court diagram
  • if two liberos have been designated as "on court" (i.e. in the lineup, not just in the player list) then use the first for sideout phase and the second for breakpoint
  • update the match metadata before saving
  • support freeball errors
  • support attack replay (A! / B!)
  • attack cover (dig) responsibility needs coding
  • prompting for files (in interactive mode) needs to be clearer about which files it is asking for (dvw vs video)
  • allow start without any dvw file
  • lineups_are_valid needs to check rosters and more, so that scouting can't start until all required info is present
  • volume control, other video controls
  • option to display court reference lines on the video pane
  • need to be able to save the file at any time (it's not currently possible from the "you need to enter info before scouting can proceed" state, because you can't get the admin modal to pop up)
  • the "Confirm end of set" dialog seems to get immediately cancelled after showing up
  • get the serving team correct at the start of a new set
  • the rally state label (over the video pane) prevents clicks in that spot
  • hide/disable the antenna inputs on the court ref for simplicity, at least until we need them
  • now that we are saving to our own intermediate format, save the whole game state at every touch, so that we can undo to any point (not just within current rally as it is now)
  • team rosters are fragile #13
  • importing teams from the "season" directory will currently create a dvw file that can't be read by dv_read, because the columns in the player metadata sections are out of order
  • if substituting the setter, ask for the new one
@raymondben
Copy link
Member

undo prior to current rally has been implemented, but needs testing, especially when loading a partially-scouted dvw or ovs file and continuing scouting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants