Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General UI considerations #5

Open
raymondben opened this issue May 7, 2022 · 2 comments
Open

General UI considerations #5

raymondben opened this issue May 7, 2022 · 2 comments

Comments

@raymondben
Copy link
Member

raymondben commented May 7, 2022

Likely to be a growing list:

  1. is it better to have one complicated pop-up per step, or a series of simpler ones. e.g. when clicking the serve end location, the first popup could simply ask for confirmation of the serve type plus the serve outcome (error, ace, reception, rotation fault). Then if ace/reception, show a second one that asks for the receiving player. If error, ask for the error rype. etc.
@raymondben
Copy link
Member Author

raymondben commented May 21, 2022

  1. the UI flow is oriented around the idea that you click the contact as it happens. But in many cases you don't know the outcome at the time of contact (e.g. shanked reception, is it a serve ace or is someone going to chase it down? Dodgy set, is it going to be called for a double contact or is it OK?) So there are many cases where you either have to guess what the outcome is, and maybe end up undoing and re-doing it, or you let the video play ahead and then rewind and do it, both of which are inefficient. Two potential solutions:

i) the NEXT ui popup has the option to modify the previous one. This is currently implemented for reception error (you can click "reception in play" on the first contact, and then on the second contact you have the option of "reception error", which will ignore the second contact location that you just clicked and instead modify the already-entered reception row to an error and the serve to an ace. The same could be done with e.g. set errors, but I am not sure if this is realistic to implement for all relevant scenarios.

ii) when a modal pops up, it includes a small video pane that plays a segment of video from (say) 1s before the clicked time to 3-5s after the clicked time, and plays it on repeat. (The time window covered by this clip could even be extended on each replay, so first time through it's -1s to +2s, then -1s to +4s, then -2s to +6s, etc). If you are unsure about something you can just watch that and hopefully not need to do/undo/redo the action. This would also help for situations where you didn't quite see what happened (did the attack deviate off the block, or the net? Which blocker touched it?)

@raymondben
Copy link
Member Author

raymondben commented May 21, 2022

Attempt at a video review pane added in 21c9464. Fixed duration, layout needs some attention to stop it overlapping the elements on the modal. (The video review pane is a separate, absolute-positioned element)

Could alternatively loop the main video in the same way, instead of having the separate review pane. The user would hide the modal (shortcut key is currently z to do this) to view the loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant