Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise test case and use ActivityScenarioRule in AdminControls and AppVersion #2785

Closed
rt4914 opened this issue Feb 25, 2021 · 1 comment
Closed

Optimise test case and use ActivityScenarioRule in AdminControls and AppVersion #2785

rt4914 opened this issue Feb 25, 2021 · 1 comment
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Feb 25, 2021

Optimise test case and use ActivityScenarioRule in AdministratorControlsActivity and AppVersionActivityTest

Advantages of using ActivityScenarioRule is that we don't need to launch the activity in each test case and thus reducing one level of nesting as well as reducing the code.
@rt4914 rt4914 modified the milestones: Beta, Backlog Feb 25, 2021
@rt4914 rt4914 self-assigned this Feb 25, 2021
@rt4914 rt4914 added Priority: Nice-to-have This work item is nice to have for its milestone. Type: Improvement labels Feb 25, 2021
@rt4914 rt4914 mentioned this issue Feb 25, 2021
Closed
@rt4914 rt4914 removed their assignment Apr 8, 2021
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. labels Sep 15, 2022
@BenHenning BenHenning removed this from the Backlog milestone Sep 16, 2022
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_type_infrastructure labels Mar 28, 2023
@adhiamboperes
Copy link
Collaborator

Closing due to ActivityScenarioRule being deprecated. See #5308 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2785 & Fixes part of #2743: A11y activity label added oppia/oppia-android
5 participants
@rt4914 @seanlip @BenHenning @adhiamboperes @Broppia