Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Buildifier with Bazel #3000

Open
anandwana001 opened this issue Mar 24, 2021 · 5 comments
Open

Use Buildifier with Bazel #3000

anandwana001 opened this issue Mar 24, 2021 · 5 comments
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@anandwana001
Copy link
Contributor

anandwana001 commented Mar 24, 2021 •
edited by adhiamboperes
Loading

Is your feature request related to a problem? Please describe.
Currently, on GitHub checks, we are using Buildifier by downloading the binary and checking the file formatting.

Describe the solution you'd like
Try to implement with Bazel on GitHub checks as well as for pre-commit.

Additional context
Reference - https://github.com/bazelbuild/buildtools/blob/master/buildifier/README.md#setup-and-usage-via-bazel

Edit: The remaining bit is adding the buildifier to pre-push checks.
@anandwana001 anandwana001 mentioned this issue Mar 24, 2021
Merged
8 tasks
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_type_infrastructure labels Mar 28, 2023
@MohitGupta121 MohitGupta121 added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label Jun 16, 2023
@BenHenning
Copy link
Member

Per @adhiamboperes's suggestion this has been completed. I'm actually not sure what it wasn't closed a while back since we've been running buildifier in CI for a few years now (and locally after running the scripts/setup.sh script). Buildifier integration will also get better integrated in an upcoming Bazel PR along with all other static script checks.

@github-actions github-actions bot reopened this Mar 29, 2024
@github-actions GitHub Actions
Copy link

The issue is reopened because of the following unresolved TODOs:

oppia-android/scripts/pre-push.sh

Line 16 in d0c8b81

# TODO(#3000): Add Bazel Linter to the project

@BenHenning
Copy link
Member

Aha, looks like there's one TODO to resolve before this can be fully closed.

@adhiamboperes adhiamboperes removed the Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. label Apr 5, 2024
@TanishMoral11
Copy link
Collaborator

Hey @BenHenning @adhiamboperes , Could you Please Clarify The changes That Need To Be Made?
Thank you!

@adhiamboperes
Copy link
Collaborator

adhiamboperes commented Dec 30, 2024 •
edited
Loading

@TanishMoral11, per the TODO, it looks like the Bazel Linter needs to be added to the project. I think the specific details can be clarified later. Could you add this issue link to the CLaM meeting discussions thread: #5602?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
7 participants
@seanlip @BenHenning @anandwana001 @adhiamboperes @MohitGupta121 @Broppia @TanishMoral11