Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Background doesn't update with theme change in Lessons Screen #5340

Closed
dmdbilal opened this issue Feb 12, 2024 · 2 comments
Closed

[BUG]: Background doesn't update with theme change in Lessons Screen #5340

dmdbilal opened this issue Feb 12, 2024 · 2 comments
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@dmdbilal
Copy link

Describe the bug

When I change the theme from light to dark, the background color remains in white.

Steps To Reproduce

Go to any topic > Lessons

Expected Behavior

The background should change as like the Revision tab.

Screenshots/Videos

Light Theme:

Screenshot 1

Dark Theme:

Screenshot 2

What device/emulator are you using?

Vivo S1 Pro

Which Android version is your device/emulator running?

Android 12

Which version of the Oppia Android app are you using?

1.0

Additional Context

No response
@dmdbilal dmdbilal added bug End user-perceivable behaviors which are not desirable. triage needed labels Feb 12, 2024
@adhiamboperes adhiamboperes added good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Feb 12, 2024
@ShubhadeepKarmakar
Copy link
Collaborator

dark_mode.mp4

I have run this app on multiple devices(Pixel 3a, Nexus 9, Redmi Note 9 Pro) and everything works fine. I mean there is no error in dark mode compatibility.

@dmdbilal
Copy link
Author

Yup, Actually my local repo is not updated to the latest. That's why this happened,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@seanlip @adhiamboperes @dmdbilal @ShubhadeepKarmakar