Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "Close" tab in the exploration player is not working #5363

Closed
ivutha2 opened this issue Mar 23, 2023 · 6 comments
Closed

The "Close" tab in the exploration player is not working #5363

ivutha2 opened this issue Mar 23, 2023 · 6 comments
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@ivutha2
Copy link

ivutha2 commented Mar 23, 2023

The close tab is not working image
@Chidinma-Egwuogu
Copy link

Hi @ivutha2, this might not be the right place to raise issues. The Outreachy/Oppia Project Site says issues should be raised here: https://github.com/oppia/oppia/issues

@ivutha2
Copy link
Author

ivutha2 commented Mar 24, 2023

Thank you @Chidinma-Egwuogu

@Chidinma-Egwuogu
Copy link

You're welcome @ivutha2 , no worries

@seanlip seanlip transferred this issue from oppia/lessons-team Mar 18, 2024
@seanlip seanlip changed the title The close tab The "Close" tab in the exploration player is not working Mar 24, 2024
@seanlip
Copy link
Member

seanlip commented Mar 24, 2024

Note: Moved to CLaM team from the lessons-team repo, since this issue is platform-related.

@seanlip seanlip added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). bug End user-perceivable behaviors which are not desirable. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Work: Low Solution is clear and broken into good-first-issue-sized chunks. and removed Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Mar 24, 2024
@theMr17
Copy link
Collaborator

theMr17 commented Mar 24, 2024

It appears that the author might have misunderstood the intent of the close button. The button is meant to close only the BottomSheetOptionsMenu, rather than closing the entire exploration. Based on my analysis, it seems that the button is working as intended by closing the menu when clicked.

@seanlip
Copy link
Member

seanlip commented Mar 24, 2024

Ah ok, thanks @theMr17! I think we can close this for now, then.

@seanlip seanlip closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@seanlip @theMr17 @Chidinma-Egwuogu @ivutha2