Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error using BDTOPO_V3 workflow (on Gimont commune - INSEE code 32147) #857

Closed
sfaraut opened this issue Oct 16, 2023 · 5 comments
Closed
Assignees
Labels
wontfix This will not be worked on

Comments

@sfaraut
Copy link

sfaraut commented Oct 16, 2023

Hi!
There is a problem using Geoclimate's BDTOPO_V3 workflow, which occurs on Gimont commune (INSEE code 32147) and latest IGN BDTOPO V3 edition (BDTOPO_3-3_TOUSTHEMES_SHP_LAMB93_D032_2023-09-15).
Problem confirmed with latest snapshot (223-10-14) and a previous one (2023-07-18), even error message is not exactly the same...
No problem when using BDTOPO_V2 workflow on BDTOPOP V2 latest data edition (BDTOPO_2-2_TOUSTHEMES_SHP_LAMB93_D032_2018-03-29).
Using Windows with same Java version for all, same conf file (except input folder)...
Seems to be related to bad processing of accentuated characters in ROAD table....

Some tests's details below (*).

Regards.
Serge.
(*)
** Test avec dernière version Geoclimate SNAPSHOT-2023-10-14

cd C:\Users\faraut\Documents\DEVELOPPEMENT\Geoclimate
"C:\Program Files\Java\jdk-11.0.17\bin\java.exe" -jar geoclimate-0.0.2-SNAPSHOT-2023-10-14.jar -f Geoclimate-resus-BDTOPO_Gimont-32147.json -w BDTOPO_V3

--> Erreur:
10:10:12.085 [main] INFO class org.orbisgis.geoclimate.bdtopo.BDTopoUtils -- Processing the commune with the code insee : 32147
10:10:12.706 [main] INFO class org.orbisgis.geoclimate.bdtopo.BDTopoUtils -- Processing the commune with the code insee : 32147
org.h2.jdbc.JdbcSQLDataException: Erreur lors de la conversion de données "CHARACTER VARYING to DECFLOAT"
Data conversion error converting "CHARACTER VARYING to DECFLOAT"; SQL statement:

        DROP TABLE IF EXISTS INPUT_ROAD [22018-224]
    at org.h2.message.DbException.getJdbcSQLException(DbException.java:518)

** Test avec version précédente SNAPSHOT-2023-07-18 et BDTOPO-V3:
-> Erreur:
C:\Users\faraut\Documents\DEVELOPPEMENT\Geoclimate>"C:\Program Files\Java\jdk-11.0.17\bin\java.exe" -jar geoclimate-0.0.2-SNAPSHOT-2023-07-18.jar -f Geoclimate-resus-BDTOPO_Gimont-32147.json -w BDTOPO_V3
The BDTOPO_V3 workflow has been started.
Please wait...
10:13:37.321 [main] INFO org.orbisgis.geoclimate.bdtopo.BDTopoUtils - Processing the commune with the code insee : 32147
10:13:37.837 [main] INFO org.orbisgis.geoclimate.bdtopo.BDTopoUtils - Processing the commune with the code insee : 32147
org.h2.jdbc.JdbcSQLDataException: Erreur lors de la conversion de données "Gué ou radier"
Data conversion error converting "Gué ou radier"; SQL statement:

        DROP TABLE IF EXISTS INPUT_ROAD [22018-214]
    at org.h2.message.DbException.getJdbcSQLException(DbException.java:506)

** Test avec dernière version Geoclimate SNAPSHOT-2023-10-14 et BDTOPO-V2
Fichier conf: Geoclimate-resus-BDTOPO-V2_Gimont-32147.json
"C:\Program Files\Java\jdk-11.0.17\bin\java.exe" -jar geoclimate-0.0.2-SNAPSHOT-2023-10-14.jar -f "Geoclimate-resus-BDTOPO-V2_Gimont-32147.json" -w BDTOPO_V2
-> Pas d'erreurs - OK!

@ebocher
Copy link
Member

ebocher commented Oct 17, 2023

The file troncon_de_route from BDTopo 3 on the department 32 is corrupted. The pos_sol columns contains a mix of integer and text values e.g "Gué ou radier"
According the BDTopo spec the pos_sol must contains only integer value.

@ebocher ebocher added the wontfix This will not be worked on label Oct 17, 2023
@ebocher ebocher closed this as completed Oct 17, 2023
@sfaraut
Copy link
Author

sfaraut commented Oct 17, 2023

Hi Erwan!
Thanks for explaination. It's really strange...
But it seems this value "Gué ou radier" is in accordance to spec (last version),...

In DC_BDTOPO_3-3.pdf ( Descriptif de contenu - Janvier 2023) page 318
(URL: https://geoservices.ign.fr/sites/default/files/2023-01/DC_BDTOPO_3-3.pdf):

Chapter 12.14 : TRONCON_DE_ROUTE
...
Position par rapport au sol
Format PostgreSQL Format Shapefile
position_par_rapport_au_sol POS_SOL
Longueur maximale : 14
Type : Liste
Valeurs possibles : 0 | 1 | -1 | 2 | -2 | 3 | -3 | 4 | -4 | Gué ou radier

@ebocher
Copy link
Member

ebocher commented Oct 17, 2023

Good catch.
Mixing integer and varchar is a very weird approach to modeling.
Another +1 for OSM.
I'll look for a workaround

@ebocher
Copy link
Member

ebocher commented Oct 27, 2023

Fix with the PR #861
Please test

@sfaraut
Copy link
Author

sfaraut commented Oct 27, 2023

Hi!
No more error now. Problem fixed!
Thanks.
Serge.

@ebocher ebocher closed this as completed Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants