Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up shared-register component #304

Open
crhistianramirez opened this issue Nov 18, 2018 · 0 comments
Open

Split up shared-register component #304

crhistianramirez opened this issue Nov 18, 2018 · 0 comments
Assignees
@crhistianramirez
Labels
architecture Change to how the app is built or architected enhancement Enhances a current feature or component

Comments

@crhistianramirez
Copy link
Contributor

This component is used when a user registers and then again when a user is logged in and is updating their profile. The conception of this shared component began as an effort to keep things DRY since much of the functionality was shared. Since then however many switch statements have been added to the template as well as the class to make it work in both scenarios which have added to the complexity and has deteriorated understandability from the perspective of an outside developer which is of course not desirable.

Refactor this one shared component into two independent components. Shared functionality can be delegated to a shared service.
@crhistianramirez crhistianramirez added enhancement Enhances a current feature or component architecture Change to how the app is built or architected labels Nov 18, 2018
@crhistianramirez crhistianramirez self-assigned this Nov 18, 2018
crhistianramirez pushed a commit to crhistianramirez/ngx-shopper that referenced this issue Nov 19, 2018
split up shared-register component into register and me-update orderc…
83149f6 
…loud-api#304
@crhistianramirez crhistianramirez mentioned this issue Nov 19, 2018
Merged
3 tasks
crhistianramirez added a commit that referenced this issue Nov 19, 2018
@crhistianramirez
Merge pull request #306 from crhistianramirez/refactor-registered
fd1208b 
split up shared-register component into register and me-update #304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crhistianramirez crhistianramirez

Labels
architecture Change to how the app is built or architected enhancement Enhances a current feature or component
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crhistianramirez