Include more data on existing tournament item DTOs

[myssto]

Tournament items returned from the API should include all of the stats that we generate. Some of the following DTOs are already implemented but as part of this process they should be double checked to ensure code quality and proper documentation.

TournamentDTO

• PlayerTournamentStatsDTO[] PlayerStats
• PlayerCompactDTO[] Players (loaded in the same manner as on the MatchDTO)

MatchDTO

• RatingAdjustmentDTO[] RatingAdjustments
• PlayerMatchStatsDTO[] PlayerStats
• MatchWinRecordDTO? WinRecord

GameDTO

• GameWinRecordDTO? WinRecord

GameScoreDTO

• Include int? Placement on the existing GameScoreDTO

[hburn7]

PlayerTournamentStatsDTO is currently designed to be attached to a player's statistics object. Therefore it is designed to be from the perspective of the player. I think having a new DTO, such as TournamentPlayerStatsDTO would be appropriate. Then we can design it to be from the perspective of the tournament which will work better imo.

RatingAdjustmentDTO currently does not feature a PlayerId field. I think doing an adhoc Dictionary, such as Dictionary<int, RatingAdjustmentDTO> would be fine here.

yay/nay/wanna fight?

[myssto]

yay/nay/wanna fight?

I choose violence

PlayerTournamentStatsDTO is currently designed to be attached to a player's statistics object. Therefore it is designed to be from the perspective of the player. I think having a new DTO, such as TournamentPlayerStatsDTO would be appropriate. Then we can design it to be from the perspective of the tournament which will work better imo.

The PlayerTournamentStats entity is 1000% not only designed to be viewed from the perspective of the player. It is simply an aggregate of a player performance over an entire tournament. Currently we use PlayerTournamentMatchCostDTO (which probably just needs to be removed in favor of a new PlayerTournamentStatsDTO based on the entity directly) to give a player performance summary for the dashboard but it can be used anywhere. I am imagining an individual tournament page can have a list of participating players, displayed in order of average match cost, average score, etc.

RatingAdjustmentDTO currently does not feature a PlayerId field. I think doing an adhoc Dictionary, such as Dictionary<int, RatingAdjustmentDTO> would be fine here.

Don't think that would be consistent with the rest of our DTOs at all. I would just add a PlayerId field to the DTO and then it can be easily tied back to the list of PlayerCompactDTO included on the match

[myssto]

lol you were right we do have a PlayerTournamentStatsDTO already, I just didn't see it because the file name is not the same as the class.

I think having a new DTO, such as TournamentPlayerStatsDTO would be appropriate

Having both TournamentPlayerStatsDTO and PlayerTournamentStatsDTO sounds like it would be incredibly confusing. What if we just found a better name for the existing PlayerTournamentStatsDTO ?