Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions to enforce code quality and style #226

Open
3 tasks
myssto opened this issue Nov 7, 2024 · 3 comments
Open
3 tasks

Add github actions to enforce code quality and style #226

myssto opened this issue Nov 7, 2024 · 3 comments

Comments

@myssto
Copy link
Contributor

myssto commented Nov 7, 2024

Depends on #227

The codebase should utilize github actions to enforce code quality with the already defined prettier and eslint rules. Contributors should be responsible for linting and formatting their code before submitting.

These actions should:

  • Run on pull requests
  • Fail if the code violates any rules

Tasks:

  • Implement a github action to build the project to ensure no build errors are present
  • Implement a github action to check code style with prettier
  • Implement a github action to check code quality with eslint
@github-project-automation github-project-automation bot moved this to Backlog in otr-beta-v2 Nov 7, 2024
@myssto myssto moved this from Backlog to Ready in otr-beta-v2 Nov 7, 2024
@myssto myssto changed the title Add code quality github actions Add github actions to enforce code quality and style Nov 7, 2024
@majorro
Copy link

majorro commented Dec 13, 2024

I can take this with #227 as well but I have some concerns about the current prettier config as it has the single rule, should be extended imo

@majorro
Copy link

majorro commented Dec 17, 2024

@myssto ?

@myssto
Copy link
Contributor Author

myssto commented Dec 18, 2024

I can take this with #227 as well but I have some concerns about the current prettier config as it has the single rule, should be extended imo

This is being handled in the admin panel branch

@myssto myssto moved this from Ready to In progress in otr-beta-v2 Dec 18, 2024
@myssto myssto moved this from In progress to Ready in otr-beta-v2 Dec 18, 2024
@hburn7 hburn7 removed this from otr-beta-v2 Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants