-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On the homepage, on desktop, focus the search bar on load #3982
Comments
@ikesau do you think there is an accessibility issue with setting the focus into the search bar on page load? We just talked with Martin and he explained that the search bar is initally a div and only the client side library turns it into an input. If this doesn't work in all cases because of this, that would be totally fine. |
@larsyencken are you aware that Marcel added a re: accessibility: it's preferable to implement this with an input's I briefly experimented with ways to improve this during the offsite - As for the UI, our Autocomplete component expands to show suggested searches as soon as it's focused: I don't think we'd want this to be the default view for the homepage, so we'd need to find a way to replicate google's behaviour (only showing suggestions after a key has been pressed) All in all, quite complex! |
Hmmm 🤔 Is this easier on the data catalog, where we implemented our own component? |
Yup! it's as simple as adding the |
Ah! I see that the So then the only work there would be hiding the dropdown when it's autofocused. |
We've decided to not autofocus the homepage because it would mean we'd have to get rid of the "Featured Searches" feature, and perhaps over-nudge users to search instead of browsing the homepage. |
Opened again in #4384 |
Problem
For a frequent user, when opening the homepage, you would most like to search for something. However, you have to click on the search bar to get started.
Proposal
On desktop, the search box should be entered on load so that you can just begin typing right away.
Technical notes
The data catalog at /data should have the same feature.
The text was updated successfully, but these errors were encountered: