Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: option to treat warnings as errors #151

Open
jfly opened this issue Sep 14, 2024 · 0 comments · May be fixed by #157
Open

Feature request: option to treat warnings as errors #151

jfly opened this issue Sep 14, 2024 · 0 comments · May be fixed by #157
Labels
A-CLI Area: command line interface A-diagnostics Area: diagnostics / error reporting C-feature Catagory: feature good first issue Good for newcomers

Comments

@jfly
Copy link

jfly commented Sep 14, 2024

Right now, nil diagnostics returns 0 (success) if the highest level diagnostic was a warning (relevant code).

I'd like to use nil in CI to enforce that there are no warnings in my code, so I'd like nil diagnostics to return non-zero if the highest level diagonstic is an error (basically, "treat warnings as errors", AKA the classic --Werror compiler flag).

I could try to put together a PR for this if you're OK with the idea.

Thanks for the great tool!

@oxalica oxalica added C-feature Catagory: feature good first issue Good for newcomers A-diagnostics Area: diagnostics / error reporting A-CLI Area: command line interface labels Nov 19, 2024
@isabelroses isabelroses linked a pull request Nov 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: command line interface A-diagnostics Area: diagnostics / error reporting C-feature Catagory: feature good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants