From 7b084c9c2b15c1f39bf878c28cb8863fadf78d19 Mon Sep 17 00:00:00 2001 From: Damiano Plebani Date: Wed, 15 Jan 2025 10:57:33 +0100 Subject: [PATCH 1/2] [IOAPPX-462] Fix flickering behaviour in the `SearchInput` on iOS (#379) ## Short description This PR fixes the flickering behaviour in the `SearchInput` on iOS. ## List of changes proposed in this pull request - Replace `ButtonLink` with `IOText` - ~~Slightly refactor the component using `reanimated` Shared Values~~ ### Preview The visual issue before the fix: https://github.com/user-attachments/assets/27b5458c-0705-4ac8-93e6-2863251c9287 ## How to test 1. Launch the example app 2. Go to the **SearchInput** screen, after enabling bolder text on iOS --- src/components/searchInput/SearchInput.tsx | 28 +++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/src/components/searchInput/SearchInput.tsx b/src/components/searchInput/SearchInput.tsx index 5e6b6d62..398e9883 100644 --- a/src/components/searchInput/SearchInput.tsx +++ b/src/components/searchInput/SearchInput.tsx @@ -37,8 +37,12 @@ import { useIOTheme } from "../../core"; import { IOFontSize, makeFontStyleObject } from "../../utils/fonts"; -import { ButtonLink } from "../buttons"; -import { IOIconSizeScale, Icon } from "../icons"; +import { Icon, IOIconSizeScale } from "../icons"; +import { + buttonTextFontSize, + buttonTextLineHeight, + IOText +} from "../typography"; /* Component visual attributes */ const inputPaddingHorizontal: IOSpacingScale = 12; @@ -280,7 +284,25 @@ export const SearchInput = forwardRef( onLayout={getCancelButtonWidth} style={[styles.cancelButton, cancelButtonAnimatedStyle]} > - + + + {cancelButtonLabel} + + ); From db6e7968b53a279ea837992fb7de0a476fcca73c Mon Sep 17 00:00:00 2001 From: Damiano Plebani Date: Wed, 15 Jan 2025 12:01:47 +0100 Subject: [PATCH 2/2] chore: release 4.4.6 --- CHANGELOG.md | 15 +++++++++++++-- package.json | 2 +- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2550b29a..d150afa2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,9 +4,13 @@ All notable changes to this project will be documented in this file. Dates are d Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). -#### [v4.4.5](https://github.com/pagopa/io-app-design-system/compare/v5.0.0-2...v4.4.5) +#### [v4.4.6](https://github.com/pagopa/io-app-design-system/compare/v5.0.0-2...v4.4.6) +- [IOAPPX-462] Fix flickering behaviour in the `SearchInput` on iOS [`#379`](https://github.com/pagopa/io-app-design-system/pull/379) - [IOAPPX-460] Fix `NumberButton` off-centre alignment when text is larger [`#378`](https://github.com/pagopa/io-app-design-system/pull/378) +- Revert "Fix flickering issue when text is bolder on iOS" [`a852bea`](https://github.com/pagopa/io-app-design-system/commit/a852bea8c9519b865c93b44cf69451f387d7627d) +- Fix flickering issue when text is bolder on iOS [`9abbcea`](https://github.com/pagopa/io-app-design-system/commit/9abbcea891a92416f6a93dae1e3ebb9080f54bea) +- chore: release 4.4.5 [`6e4f1b6`](https://github.com/pagopa/io-app-design-system/commit/6e4f1b65b0359e6a75971eddffa500facdd65790) #### [v5.0.0-2](https://github.com/pagopa/io-app-design-system/compare/v5.0.0-1...v5.0.0-2) @@ -29,7 +33,7 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). - chore: release 5.0.0-1 [`7eba376`](https://github.com/pagopa/io-app-design-system/commit/7eba376ab3b8b695041c46f4777ae12d3d001f43) - chore: release 4.4.4 [`3a52bb7`](https://github.com/pagopa/io-app-design-system/commit/3a52bb766c40e79f178685fff0b05b7eb0ccdc36) -#### [v5.0.0-0](https://github.com/pagopa/io-app-design-system/compare/v4.4.4...v5.0.0-0) +#### [v5.0.0-0](https://github.com/pagopa/io-app-design-system/compare/v4.4.5...v5.0.0-0) > 20 December 2024 @@ -37,6 +41,13 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). - Update `jest` snapshots [`47d1f88`](https://github.com/pagopa/io-app-design-system/commit/47d1f88c017bc69b245c6996f61884e396bb8dc5) - Update `jest` snapshots [`30076b9`](https://github.com/pagopa/io-app-design-system/commit/30076b93887ccf211ad03a02e4ed2700997b1300) +#### [v4.4.5](https://github.com/pagopa/io-app-design-system/compare/v4.4.4...v4.4.5) + +> 9 January 2025 + +- [IOAPPX-460] Fix `NumberButton` off-centre alignment when text is larger [`#378`](https://github.com/pagopa/io-app-design-system/pull/378) +- chore: release 4.4.5 [`6e4f1b6`](https://github.com/pagopa/io-app-design-system/commit/6e4f1b65b0359e6a75971eddffa500facdd65790) + #### [v4.4.4](https://github.com/pagopa/io-app-design-system/compare/v4.4.3...v4.4.4) > 7 January 2025 diff --git a/package.json b/package.json index 2e0543f7..25fbaa72 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@pagopa/io-app-design-system", - "version": "4.4.5", + "version": "4.4.6", "description": "The library defining the core components of the design system of @pagopa/io-app", "main": "lib/commonjs/index", "module": "lib/module/index",