diff --git a/src/DeepLabCut/deeplabcut/utils/auxfun_models.py b/src/DeepLabCut/deeplabcut/utils/auxfun_models.py index b41a43e..740f874 100644 --- a/src/DeepLabCut/deeplabcut/utils/auxfun_models.py +++ b/src/DeepLabCut/deeplabcut/utils/auxfun_models.py @@ -48,7 +48,26 @@ def Downloadweights(modeltype,model_path): print("Downloading a ImageNet-pretrained model from {}....".format(url)) response = urllib.request.urlopen(url) with tarfile.open(fileobj=BytesIO(response.read()), mode='r:gz') as tar: - tar.extractall(path=target_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=target_dir) except KeyError: print("Model does not exist: ", modeltype) print("Pick one of the following: ", neturls.keys())