You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current behaviour for FWs is to set the _last_light_position only when transitioning between a light and dark filter. This means that _last_light_position is not necessarily set during normal usage, which can lead to errors such as the FW staying in the dark position during autofocusing.
Suggestion is either to set the initial light position explicitly in the config, or to select one from filter_names during initialisation.
_last_light_position is supposed to be the most recently used filter that is not the 'blank' used for taking darks. If the blank is the only filter that has been used since starting up it should be None, nothing else makes sense in this context.
The fact that _last_light_position is initially not set is not the real problem here, the problem is that we have code that takes exposures (that are not darks) without specifying a filter. We should be fixing that instead.
The current behaviour for FWs is to set the
_last_light_position
only when transitioning between a light and dark filter. This means that_last_light_position
is not necessarily set during normal usage, which can lead to errors such as the FW staying in the dark position during autofocusing.Suggestion is either to set the initial light position explicitly in the config, or to select one from
filter_names
during initialisation.Code:
POCS/src/panoptes/pocs/filterwheel/filterwheel.py
Line 62 in 804e48d
The text was updated successfully, but these errors were encountered: