Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS is not loading correctly in feature specs #61

Open
dimanyc opened this issue May 15, 2020 · 0 comments
Open

JS is not loading correctly in feature specs #61

dimanyc opened this issue May 15, 2020 · 0 comments

Comments

@dimanyc
Copy link
Member

dimanyc commented May 15, 2020

Looks JS is not loading in feature specs. Seeing the following error in Capybara:

image
dimanyc added a commit that referenced this issue May 15, 2020
@dimanyc
Prefixes phone number based on selected country
430940c 
as requested in https://www.notion.so/Apply-Form-pre-fill-country-code-13efee17e5754d4fa43690f2d80f7a25,
this diff enables prefixing of volunteer Phone field with international
country code based on selected country to speed up the submission
process.

- adds a new Gem [^1] for fetching country codes
- adds a new route for sending GET requests with alpha2 country params
  and getting back the country code
- adds a feature spec for checking the implementation. This spec is
  currently disabled because our JS is not loading in test env. Filed a
  separate issue here: #61

[^1]: [Countries Gem](https://github.com/hexorx/countries).
@dimanyc dimanyc mentioned this issue May 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dimanyc