fatxpool: transaction reported as invalid during block building shall be removed from the pool

[michalkucharczyk]

Currently the transaction which reported as invalid by a block builder is silently skipped:

polkadot-sdk/substrate/client/transaction-pool/src/fork_aware_txpool/fork_aware_txpool.rs

Lines 716 to 729 in 5b8e409

	/// Intended to remove transactions identified by the given hashes, and any dependent
	/// transactions, from the pool. In current implementation this function only outputs the error.
	/// Seems that API change is needed here to make this call reasonable.
	// todo [#5491]: api change? we need block hash here (assuming we need it at all - could be
	// useful for verification for debugging purposes).
	fn remove_invalid(&self, hashes: &[TxHash<Self>]) -> Vec<Arc<Self::InPoolTransaction>> {
	if !hashes.is_empty() {
	log::debug!(target: LOG_TARGET, "fatp::remove_invalid {}", hashes.len());
	log_xt_trace!(target:LOG_TARGET, hashes, "[{:?}] fatp::remove_invalid");
	self.metrics
	.report(|metrics| metrics.removed_invalid_txs.inc_by(hashes.len() as _));
	}
	Default::default()
	}

Current behavior requires improvements - transaction shall be removed from the view, and also from the fatp. Invalid event shall be dispatched.