-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging with pkg doesn't work #120
Comments
ping @s-h-a-d-o-w |
Holy crap, that actually works, thanks! I get a different error now by the way - renaming to node.exe also resolves that one:
|
Renaming the executable to node.exe is a bad way to get it to work. How to:
Now it does work, but the node (cmd window?) opens up when I run the main.exe file: @parro-it any official way of packaging the application? Sorry if I missed any docs regarding this, Thank you |
This may help: https://github.com/s-h-a-d-o-w/create-nodew-exe More info: nodejs/node#556 |
The exe file created by this tool exits silently without warnings or errors as soon as it's executed |
Hmm, perhaps launchui could work for you: |
I haven't tried it with
|
This also works:
Thanks for letting us know about The unfortunate thing is that it doesn't fully solve the problem. Because what if the user decides to rename the .exe? I know I sometimes rename files whenever I feel that the devs chose idiotic names. (Like Microsoft calling their things e.g. "vssetup.exe" - how is that helpful? No version number, no nothing...) |
launchui-packager seems to keep the main JavaScript app file exposed in the |
@s-h-a-d-o-w I cannot get the |
I assume getting the resulting .exe to run is the problem, right? Because above, you said that it was able to do the conversion sucessfully. Did you try the precise commands that I listed? |
Yes, it successfully creates an exe file but nothing happens when I run it
This is the command I'm using: |
Obviously, once one has written those small tools using libui, they also need to be distributed somehow...
But I got the following error running the exe pkg generated (
Trying to require ...
is debug output that I added in nbind.js):The weird thing is that that file actually exists. And I am able to require that exact path in a dummy script that does nothing else.
Someone reported the same issue with their code here: vercel/pkg#471
But I can't tell what actually causes this and where it should be addressed (pkg, nbind or... could it maybe even be a node bug?). Which is why I create this issue here instead of at nbind - maybe you have sufficient knowledge of the matter to trace it to a definite source and through that make packaging with pkg work.
The text was updated successfully, but these errors were encountered: