Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiration of APN Development Certificate causes Production Deployment to Crash #162

Open
NicksonYap opened this issue Jul 27, 2020 · 0 comments

Comments

@NicksonYap
Copy link

Hi,

Firstly thanks for this package, saving us devs countless hours (or days & weeks!)

However there may be a concerning issue here
(essentially a yearly time bomb for all applications using Parse Push Adapter)

I have both development & production cert configured Parse Push, that was deployed in production

Upon expiry of the Development cert, the Production deployment went down
Embarrassingly, it stayed down for 3 whole days...

Yes, I had included Development cert in Production deployment
(probably a mistake but has been working fine for a whole year until now)

developer.apple.com:
image

As you can see, Development cert expires at about 1 month earlier than Production (see the 2021 expiry ones)
Development cert for 2020 has already expired and disappeared from above

Problem is, I did receive email notification of expiry, but for Production cert only!
image

Because parse-server-push-adapter triggers a crash also on Development cert which expires 1 month before the Production cert,
this renders the Production cert expiry notification useless (in my case at least)

I have commented out Development cert in production as a quick fix
then finally renewed the Production cert while leaving Development cert disabled

Conclusion:
Perhaps expiry of Development Cert should not crash but only warn in console log (or even better, set up email notification)
Note in Documentation or remove/disabled Development cert in Production?

In my case the instance was down during the weekends so it's not as severe but I think this is important to note for other developers/applications

Best,
Nickson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant