Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage is outdated and not being used #29

Open
simonrouse9461 opened this issue Jan 7, 2025 · 0 comments
Open

Code coverage is outdated and not being used #29

simonrouse9461 opened this issue Jan 7, 2025 · 0 comments
Assignees
Labels
build Related to CI builds

Comments

@simonrouse9461
Copy link
Member

Currently we are using actions-rs/grcov for generating code coverage report. However, it's been failing for a long time.

Root causes:

  • Latest builds require a newer version rust toolchain (>= 1.82), which is not compatible with actions-rs/grcov.
  • actions-rs/grcov has been marked as archived.
    • actions-rs/grcov relies on -Zprofile flag from old nightly rust toolchain.
    • In newer versions of rust, -Zprofile has been removed

We can use alternative ways to generate coverage reports, but as suggested by @alancai98, it's not actually needed for this repo at the moment as we are not running any test cases.

Solution: @alancai98 suggests that we should just remove coverage.yml along with codecov.yml. We can add them back once needed.

@simonrouse9461 simonrouse9461 self-assigned this Jan 7, 2025
@simonrouse9461 simonrouse9461 added the build Related to CI builds label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI builds
Projects
None yet
Development

No branches or pull requests

1 participant