Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate some of the typings #75

Closed
parzhitsky opened this issue May 23, 2020 · 0 comments · Fixed by #79
Closed

Deprecate some of the typings #75

parzhitsky opened this issue May 23, 2020 · 0 comments · Fixed by #79
Labels
Change: patch [Issue / PR] describes a small non-breaking change, such as bugfix or an optimization Domain: main [Issue / PR] describes change in the functionality, its optimization Pending: unclear [Issue] not yet fully defined Priority: medium [Issue / PR] should be addressed without delay Type: improvement [Issue / PR] addresses lack of a functionality or an open possibility of enhancement

Comments

@parzhitsky
Copy link
Member

parzhitsky commented May 23, 2020 •
edited
Loading

When updating signature of retry.after by #62, the Retryer type have to be updated independently as well. This is not only inconvenient, but also error prone.

Find and deprecate 👮‍♂️ (and later remove in #12) such types.
@parzhitsky parzhitsky added Change: patch [Issue / PR] describes a small non-breaking change, such as bugfix or an optimization Domain: main [Issue / PR] describes change in the functionality, its optimization Priority: medium [Issue / PR] should be addressed without delay Type: improvement [Issue / PR] addresses lack of a functionality or an open possibility of enhancement labels May 23, 2020
@parzhitsky parzhitsky mentioned this issue May 24, 2020
Merged
parzhitsky added a commit that referenced this issue May 24, 2020
@parzhitsky
Acknowledge that there's no issue (#75)
4eb1f8b
@parzhitsky parzhitsky mentioned this issue May 24, 2020
Merged
@parzhitsky parzhitsky added the Pending: unclear [Issue] not yet fully defined label May 24, 2020
parzhitsky added a commit that referenced this issue Jul 19, 2020
@parzhitsky
Remove duplication (#75)
a196b49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Change: patch [Issue / PR] describes a small non-breaking change, such as bugfix or an optimization Domain: main [Issue / PR] describes change in the functionality, its optimization Pending: unclear [Issue] not yet fully defined Priority: medium [Issue / PR] should be addressed without delay Type: improvement [Issue / PR] addresses lack of a functionality or an open possibility of enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deal with error prone types parzh/retryable
1 participant
@parzhitsky