Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink styles used for slider ticks/tracks and progress bar tracks #1316

Closed
lboehling opened this issue Jul 8, 2024 · 2 comments
Closed
Assignees
Labels
PatternFly 6 Design issues related to Penta work Visual design

Comments

@lboehling
Copy link

The tokens we use in v6 for our sliders and progress bars work well for the light themes but don't translate well to the dark themes. The slider/progress tracks don't have enough contrast with the dark brand token value, and the slider tick marks in the dark theme don't show against the track color. Need to either use different existing tokens here or create new tokens.

Sliders:

Screenshot 2024-07-08 at 10 41 39 AM Screenshot 2024-07-08 at 10 41 35 AM Screenshot 2024-07-08 at 10 41 50 AM Screenshot 2024-07-08 at 10 41 55 AM

Progress bars:

Screenshot 2024-07-08 at 10 45 06 AM Screenshot 2024-07-08 at 10 45 14 AM
@lboehling lboehling added Visual design PatternFly 6 Design issues related to Penta work labels Jul 8, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jul 8, 2024
@lboehling lboehling self-assigned this Aug 13, 2024
@lboehling
Copy link
Author

lboehling commented Aug 13, 2024

I see a couple different solutions for this:

First option would be:

-Base token updates:

  • Adjust dark palette base values for color--nonstatus--gray (nonstatus--gray--100 to gray-60, nonstatus--gray--200 to gray-50 and nonstatus--gray--300 to gray-40)
  • Adjust semantic tokens for on-gray text & on-gray icon to use text--color--regular and icon--color--regular
    note: this will change the dark theme gray label, but i think it's a nice update actually since the current gray label looks very similar to the disabled label in dark theme

-Progress bar:
(No changes in core needed, would be handled at token level with the adjustments above)
image

-Slider:

  • track: adjust bkg color to use nonstatus gray bkg color token
  • tick: adjust filled tick color to use icon--color--on-brand
  • tick: adjust disabled tick color to use icon--color--on-disabled
  • tick: adjust border radius to border--radius--sharp
  • tick: adjust width to .15rem
image image

OR second option:

Possibly consider adding in new tokens for track/tick bkg color that would be used across slider/progress components. this would require more updates in core to both progress and slider components once made.
--global--color--track--unfilled--default
--global--color--track--filled--brand
--global--color--track--filled--warning
--global--color--track--filled--danger
--global--color--track--filled--success
--global--icon--color--tick--unfilled--default
--global--icon--color--tick--filled--on-brand
--global--icon--color--tick--filled--on-warning
--global--icon--color--tick--filled--on-danger
--global--icon--color--tick--filled--on-success

@lboehling
Copy link
Author

lboehling commented Aug 14, 2024

After reviewing with @andrew-ronaldson and @mcoker, we decided to go with option 1. Tokens and components have been updated in Figma! Opening a follow up issue in core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PatternFly 6 Design issues related to Penta work Visual design
Projects
Archived in project
Development

No branches or pull requests

1 participant