From d5613e1e6d582017368dd61fcc212f15fb3d1da7 Mon Sep 17 00:00:00 2001 From: Titani Date: Thu, 26 Oct 2023 16:24:44 -0400 Subject: [PATCH 01/12] chore(deps): Bump v6 branch to latest core alpha --- packages/react-core/package.json | 2 +- .../src/components/Masthead/Masthead.tsx | 5 --- .../components/Masthead/examples/Masthead.md | 44 ------------------- .../NotificationBadge/NotificationBadge.tsx | 2 +- packages/react-docs/package.json | 2 +- packages/react-icons/package.json | 2 +- packages/react-styles/package.json | 2 +- packages/react-tokens/package.json | 2 +- yarn.lock | 8 ++-- 9 files changed, 10 insertions(+), 59 deletions(-) diff --git a/packages/react-core/package.json b/packages/react-core/package.json index 55628712808..a5ded2fd186 100644 --- a/packages/react-core/package.json +++ b/packages/react-core/package.json @@ -54,7 +54,7 @@ "tslib": "^2.5.0" }, "devDependencies": { - "@patternfly/patternfly": "5.2.0-prerelease.3", + "@patternfly/patternfly": "6.0.0-alpha.10", "@rollup/plugin-commonjs": "^25.0.0", "@rollup/plugin-node-resolve": "^15.0.2", "@rollup/plugin-replace": "^5.0.2", diff --git a/packages/react-core/src/components/Masthead/Masthead.tsx b/packages/react-core/src/components/Masthead/Masthead.tsx index 897f7e2f0c5..990c6fc353b 100644 --- a/packages/react-core/src/components/Masthead/Masthead.tsx +++ b/packages/react-core/src/components/Masthead/Masthead.tsx @@ -9,8 +9,6 @@ export interface MastheadProps extends React.DetailedHTMLProps = ({ children, className, - backgroundColor = 'dark', display = { md: 'inline' }, @@ -48,8 +45,6 @@ export const Masthead: React.FunctionComponent = ({ styles.masthead, formatBreakpointMods(display, styles, 'display-', getBreakpoint(width)), formatBreakpointMods(inset, styles, '', getBreakpoint(width)), - backgroundColor === 'light' && styles.modifiers.light, - backgroundColor === 'light200' && styles.modifiers.light_200, className )} {...props} diff --git a/packages/react-core/src/components/Masthead/examples/Masthead.md b/packages/react-core/src/components/Masthead/examples/Masthead.md index 5a6215bc494..94563b6cd8e 100644 --- a/packages/react-core/src/components/Masthead/examples/Masthead.md +++ b/packages/react-core/src/components/Masthead/examples/Masthead.md @@ -140,50 +140,6 @@ import BarsIcon from '@patternfly/react-icons/dist/js/icons/bars-icon'; ; ``` -### Light variant - -```ts -import React from 'react'; -import { Masthead, MastheadToggle, MastheadMain, MastheadBrand, MastheadContent, Button } from '@patternfly/react-core'; -import BarsIcon from '@patternfly/react-icons/dist/js/icons/bars-icon'; - - - - - - - Logo - - - Content - -; -``` - -### Light 200 variant - -```ts -import React from 'react'; -import { Masthead, MastheadToggle, MastheadMain, MastheadBrand, MastheadContent, Button } from '@patternfly/react-core'; -import BarsIcon from '@patternfly/react-icons/dist/js/icons/bars-icon'; - - - - - - - Logo - - - Content - -; -``` - ### Inset ```ts diff --git a/packages/react-core/src/components/NotificationBadge/NotificationBadge.tsx b/packages/react-core/src/components/NotificationBadge/NotificationBadge.tsx index dbc08233a55..34d00d83357 100644 --- a/packages/react-core/src/components/NotificationBadge/NotificationBadge.tsx +++ b/packages/react-core/src/components/NotificationBadge/NotificationBadge.tsx @@ -54,7 +54,7 @@ export const NotificationBadge: React.FunctionComponent className={css(styles.notificationBadge, styles.modifiers[variant], isExpanded && styles.modifiers.expanded)} > {notificationChild} - {count > 0 && {count}} + {count > 0 && {count}} ); diff --git a/packages/react-docs/package.json b/packages/react-docs/package.json index 520f80ff5f2..ef17ec2c7d4 100644 --- a/packages/react-docs/package.json +++ b/packages/react-docs/package.json @@ -23,7 +23,7 @@ "test:a11y": "patternfly-a11y --config patternfly-a11y.config" }, "dependencies": { - "@patternfly/patternfly": "5.2.0-prerelease.3", + "@patternfly/patternfly": "6.0.0-alpha.10", "@patternfly/react-charts": "^8.0.0-alpha.1", "@patternfly/react-code-editor": "^6.0.0-alpha.1", "@patternfly/react-core": "^6.0.0-alpha.1", diff --git a/packages/react-icons/package.json b/packages/react-icons/package.json index a8edba50dff..e0c3a89a3d5 100644 --- a/packages/react-icons/package.json +++ b/packages/react-icons/package.json @@ -33,7 +33,7 @@ "@fortawesome/free-brands-svg-icons": "^5.14.0", "@fortawesome/free-regular-svg-icons": "^5.14.0", "@fortawesome/free-solid-svg-icons": "^5.14.0", - "@patternfly/patternfly": "5.2.0-prerelease.3", + "@patternfly/patternfly": "6.0.0-alpha.10", "fs-extra": "^11.1.1", "glob": "^7.1.2", "rimraf": "^2.6.2", diff --git a/packages/react-styles/package.json b/packages/react-styles/package.json index 33d52d5d9ca..05248b40d19 100644 --- a/packages/react-styles/package.json +++ b/packages/react-styles/package.json @@ -19,7 +19,7 @@ "clean": "rimraf dist css" }, "devDependencies": { - "@patternfly/patternfly": "5.2.0-prerelease.3", + "@patternfly/patternfly": "6.0.0-alpha.10", "camel-case": "^3.0.0", "css": "^2.2.3", "fs-extra": "^11.1.1", diff --git a/packages/react-tokens/package.json b/packages/react-tokens/package.json index 409db237c11..7af0361591b 100644 --- a/packages/react-tokens/package.json +++ b/packages/react-tokens/package.json @@ -29,7 +29,7 @@ "clean": "rimraf dist" }, "devDependencies": { - "@patternfly/patternfly": "5.2.0-prerelease.3", + "@patternfly/patternfly": "6.0.0-alpha.10", "css": "^2.2.3", "fs-extra": "^11.1.1", "glob": "^7.1.2", diff --git a/yarn.lock b/yarn.lock index ade3ebd7fa7..9dce95adfa4 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3909,10 +3909,10 @@ puppeteer-cluster "^0.23.0" xmldoc "^1.1.2" -"@patternfly/patternfly@5.2.0-prerelease.3": - version "5.2.0-prerelease.3" - resolved "https://registry.yarnpkg.com/@patternfly/patternfly/-/patternfly-5.2.0-prerelease.3.tgz#d114fbe3c03e98d1ca9e20447fd8beaf1a4d2ddc" - integrity sha512-TTiK+QLC+TP/Gyn6uJPDIwvYhKM/gifoJ2bi9ZY186OCHddOTdG5qwKQA83a0tK08O0d4hr/Ep76HUpc5MDIfw== +"@patternfly/patternfly@6.0.0-alpha.10": + version "6.0.0-alpha.10" + resolved "https://registry.yarnpkg.com/@patternfly/patternfly/-/patternfly-6.0.0-alpha.10.tgz#000908bbe91e5cbfb9eaa6443f736e04a81fa733" + integrity sha512-iZjLH4J0WYlgq9BUs7kQAJTQv0qfkr7+LRq39GEGOVvw7fmEZ6nhTaagXFgOSPziavNoGjg/iy4Nb6SPaPtPIA== "@pkgjs/parseargs@^0.11.0": version "0.11.0" From 0d59f4f4ca854f6a1f77a80cf957cac5e4c2355a Mon Sep 17 00:00:00 2001 From: Titani Date: Fri, 27 Oct 2023 11:49:19 -0400 Subject: [PATCH 02/12] update snapshts --- .../components/Nav/__tests__/__snapshots__/Nav.test.tsx.snap | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/react-core/src/components/Nav/__tests__/__snapshots__/Nav.test.tsx.snap b/packages/react-core/src/components/Nav/__tests__/__snapshots__/Nav.test.tsx.snap index dce2e3c6f9f..7875badf686 100644 --- a/packages/react-core/src/components/Nav/__tests__/__snapshots__/Nav.test.tsx.snap +++ b/packages/react-core/src/components/Nav/__tests__/__snapshots__/Nav.test.tsx.snap @@ -1093,10 +1093,7 @@ exports[`Nav Nav List with flyout 1`] = `
Flyout test From e09fa6ec98050035d7bcd530ba38be93f003f678 Mon Sep 17 00:00:00 2001 From: Titani Date: Fri, 27 Oct 2023 16:19:18 -0400 Subject: [PATCH 03/12] fixes from review --- .../components/Nav/__tests__/__snapshots__/Nav.test.tsx.snap | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/react-core/src/components/Nav/__tests__/__snapshots__/Nav.test.tsx.snap b/packages/react-core/src/components/Nav/__tests__/__snapshots__/Nav.test.tsx.snap index 7875badf686..dce2e3c6f9f 100644 --- a/packages/react-core/src/components/Nav/__tests__/__snapshots__/Nav.test.tsx.snap +++ b/packages/react-core/src/components/Nav/__tests__/__snapshots__/Nav.test.tsx.snap @@ -1093,7 +1093,10 @@ exports[`Nav Nav List with flyout 1`] = `
Flyout test From 3d5b7cc81c2c67cf7665459195b70cc89d278cae Mon Sep 17 00:00:00 2001 From: Titani Date: Fri, 27 Oct 2023 17:14:55 -0400 Subject: [PATCH 04/12] fix test --- .../integration/tableeditablecompoundexpandable.spec.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-integration/cypress/integration/tableeditablecompoundexpandable.spec.ts b/packages/react-integration/cypress/integration/tableeditablecompoundexpandable.spec.ts index 65d860ae65c..7a0339674ee 100644 --- a/packages/react-integration/cypress/integration/tableeditablecompoundexpandable.spec.ts +++ b/packages/react-integration/cypress/integration/tableeditablecompoundexpandable.spec.ts @@ -4,9 +4,9 @@ describe('Table Compound Expandable Test', () => { }); it('Test expandable/collapsible', () => { - cy.get('button.pf-v5-c-table__button').first().click(); + cy.get('#expandable-toggle-0-1').first().click(); - cy.get('button.pf-v5-c-table__button').first().click(); + cy.get('#expandable-toggle-0-1').first().click(); // should not have changed the url cy.url().should('eq', 'http://localhost:3000/table-editable-compound-expandable-demo-nav-link'); From d59a2d3f2b9fd480c0a6ebdf61cab9649fdc6925 Mon Sep 17 00:00:00 2001 From: Titani Date: Tue, 31 Oct 2023 12:11:03 -0400 Subject: [PATCH 05/12] update to alpha 12 to fix table issue --- packages/react-core/package.json | 2 +- packages/react-core/src/components/Page/PageSection.tsx | 7 ++----- packages/react-core/src/components/Page/PageSidebar.tsx | 4 ---- .../components/PageHeader/PageHeaderToolsItem.tsx | 4 ---- packages/react-docs/package.json | 2 +- packages/react-icons/package.json | 2 +- packages/react-styles/package.json | 2 +- packages/react-tokens/package.json | 2 +- yarn.lock | 8 ++++---- 9 files changed, 11 insertions(+), 22 deletions(-) diff --git a/packages/react-core/package.json b/packages/react-core/package.json index a5ded2fd186..8ccb4e0c4e6 100644 --- a/packages/react-core/package.json +++ b/packages/react-core/package.json @@ -54,7 +54,7 @@ "tslib": "^2.5.0" }, "devDependencies": { - "@patternfly/patternfly": "6.0.0-alpha.10", + "@patternfly/patternfly": "6.0.0-alpha.12", "@rollup/plugin-commonjs": "^25.0.0", "@rollup/plugin-node-resolve": "^15.0.2", "@rollup/plugin-replace": "^5.0.2", diff --git a/packages/react-core/src/components/Page/PageSection.tsx b/packages/react-core/src/components/Page/PageSection.tsx index 0793f85d83e..aa4806760db 100644 --- a/packages/react-core/src/components/Page/PageSection.tsx +++ b/packages/react-core/src/components/Page/PageSection.tsx @@ -26,7 +26,7 @@ export interface PageSectionProps extends React.HTMLProps { /** Additional classes added to the section */ className?: string; /** Section background color variant */ - variant?: 'default' | 'light' | 'dark' | 'darker'; + variant?: 'default'; /** Section type variant */ type?: 'default' | 'nav' | 'subnav' | 'breadcrumb' | 'tabs' | 'wizard'; /** Enables the page section to fill the available vertical space */ @@ -77,10 +77,7 @@ const variantType = { }; const variantStyle = { - [PageSectionVariants.default]: '', - [PageSectionVariants.light]: styles.modifiers.light, - [PageSectionVariants.dark]: styles.modifiers.dark_200, - [PageSectionVariants.darker]: styles.modifiers.dark_100 + [PageSectionVariants.default]: '' }; export const PageSection: React.FunctionComponent = ({ diff --git a/packages/react-core/src/components/Page/PageSidebar.tsx b/packages/react-core/src/components/Page/PageSidebar.tsx index 8e5f6a610a9..df6b5f63bbe 100644 --- a/packages/react-core/src/components/Page/PageSidebar.tsx +++ b/packages/react-core/src/components/Page/PageSidebar.tsx @@ -15,8 +15,6 @@ export interface PageSidebarProps extends React.HTMLProps { isManagedSidebar?: boolean; /** Programmatically manage if the sidebar is shown, if isManagedSidebar is set to true in the Page component, this prop is managed */ isSidebarOpen?: boolean; - /** Indicates the color scheme of the sidebar */ - theme?: 'dark' | 'light'; /** Sidebar id */ id?: string; } @@ -33,7 +31,6 @@ export const PageSidebar: React.FunctionComponent = ({ className = '', children, isSidebarOpen = true, - theme = 'dark', id = 'page-sidebar', ...props }: PageSidebarProps) => ( @@ -46,7 +43,6 @@ export const PageSidebar: React.FunctionComponent = ({ id={id} className={css( styles.pageSidebar, - theme === 'light' && styles.modifiers.light, sidebarOpen && styles.modifiers.expanded, !sidebarOpen && styles.modifiers.collapsed, className diff --git a/packages/react-core/src/deprecated/components/PageHeader/PageHeaderToolsItem.tsx b/packages/react-core/src/deprecated/components/PageHeader/PageHeaderToolsItem.tsx index 0403389ff53..56fce766e17 100644 --- a/packages/react-core/src/deprecated/components/PageHeader/PageHeaderToolsItem.tsx +++ b/packages/react-core/src/deprecated/components/PageHeader/PageHeaderToolsItem.tsx @@ -20,8 +20,6 @@ export interface PageHeaderToolsItemProps extends React.HTMLProps = ({ @@ -29,7 +27,6 @@ export const PageHeaderToolsItem: React.FunctionComponent { const { width, getBreakpoint } = React.useContext(PageContext); @@ -37,7 +34,6 @@ export const PageHeaderToolsItem: React.FunctionComponent Date: Tue, 31 Oct 2023 13:29:32 -0400 Subject: [PATCH 06/12] more fixes --- .../src/components/Page/PageSection.tsx | 5 +- .../__tests__/Generated/PageSidebar.test.tsx | 2 +- .../components/Page/__tests__/Page.test.tsx | 2 +- .../__snapshots__/Page.test.tsx.snap | 78 +++++++++---------- .../Page/examples/PageGroupSection.tsx | 7 +- .../Page/examples/PageHorizontalNav.tsx | 7 +- .../Page/examples/PageMainSectionPadding.tsx | 9 +-- .../Page/examples/PageMultipleSidebarBody.tsx | 7 +- .../Page/examples/PageTertiaryNav.tsx | 7 +- .../Page/examples/PageUncontrolledNav.tsx | 7 +- .../Page/examples/PageVerticalNav.tsx | 7 +- .../examples/NotificationDrawerGrouped.tsx | 5 +- ...stheadWithUtilitiesAndUserDropdownMenu.tsx | 3 +- .../Page/PageStickySectionBreadcrumb.tsx | 3 +- ...ageVerticalNavUsingPageHeaderComponent.tsx | 8 +- .../tests/PageHeaderToolsItem.test.tsx | 4 +- .../PageHeaderToolsItem.test.tsx.snap | 2 +- .../cypress/integration/page.spec.ts | 2 - .../pagemanagedsidebarclosed.spec.ts | 2 - .../demos/BackToTopDemo/BackToTopDemo.tsx | 3 +- .../components/demos/PageDemo/PageDemo.tsx | 25 +++--- .../PageDemo/PageManagedSidebarClosedDemo.tsx | 5 +- 22 files changed, 84 insertions(+), 116 deletions(-) diff --git a/packages/react-core/src/components/Page/PageSection.tsx b/packages/react-core/src/components/Page/PageSection.tsx index aa4806760db..b3b7ed03c92 100644 --- a/packages/react-core/src/components/Page/PageSection.tsx +++ b/packages/react-core/src/components/Page/PageSection.tsx @@ -5,10 +5,7 @@ import { formatBreakpointMods } from '../../helpers/util'; import { PageContext } from './PageContext'; export enum PageSectionVariants { - default = 'default', - light = 'light', - dark = 'dark', - darker = 'darker' + default = 'default' } export enum PageSectionTypes { diff --git a/packages/react-core/src/components/Page/__tests__/Generated/PageSidebar.test.tsx b/packages/react-core/src/components/Page/__tests__/Generated/PageSidebar.test.tsx index 6653c233175..27317fbcfe0 100644 --- a/packages/react-core/src/components/Page/__tests__/Generated/PageSidebar.test.tsx +++ b/packages/react-core/src/components/Page/__tests__/Generated/PageSidebar.test.tsx @@ -9,7 +9,7 @@ import {} from '../..'; it('PageSidebar should match snapshot (auto-generated)', () => { const { asFragment } = render( - +
ReactNode
); diff --git a/packages/react-core/src/components/Page/__tests__/Page.test.tsx b/packages/react-core/src/components/Page/__tests__/Page.test.tsx index 4bcee0f4cc8..537f453438e 100644 --- a/packages/react-core/src/components/Page/__tests__/Page.test.tsx +++ b/packages/react-core/src/components/Page/__tests__/Page.test.tsx @@ -44,7 +44,7 @@ describe('Page', () => { test('Check dark page against snapshot', () => { const Header = undefined} />; const Sidebar = ( - + Navigation ); diff --git a/packages/react-core/src/components/Page/__tests__/__snapshots__/Page.test.tsx.snap b/packages/react-core/src/components/Page/__tests__/__snapshots__/Page.test.tsx.snap index 1843b06aabc..a1f5a60f8bd 100644 --- a/packages/react-core/src/components/Page/__tests__/__snapshots__/Page.test.tsx.snap +++ b/packages/react-core/src/components/Page/__tests__/__snapshots__/Page.test.tsx.snap @@ -42,17 +42,17 @@ exports[`Page Check dark page against snapshot 1`] = ` Section with default background
Section with light background
Section with dark background
Section with darker background
@@ -102,17 +102,17 @@ exports[`Page Check page horizontal layout example against snapshot 1`] = ` Section with default background
Section with light background
Section with dark background
Section with darker background
@@ -266,17 +266,17 @@ exports[`Page Check page to verify breadcrumb is created - PageBreadcrumb syntax Section with default background
Section with light background
Section with dark background
Section with darker background
@@ -430,17 +430,17 @@ exports[`Page Check page to verify breadcrumb is created 1`] = ` Section with default background
Section with light background
Section with dark background
Section with darker background
@@ -714,17 +714,17 @@ exports[`Page Check page to verify grouped nav and breadcrumb - new components s Section with default background
Section with light background
Section with dark background
Section with darker background
@@ -1005,17 +1005,17 @@ exports[`Page Check page to verify grouped nav and breadcrumb - old / props synt Section with default background
Section with light background
Section with dark background
Section with darker background
@@ -1181,17 +1181,17 @@ exports[`Page Check page to verify nav is created - PageNavigation syntax 1`] = Section with default background
Section with light background
Section with dark background
Section with darker background
@@ -1361,17 +1361,17 @@ exports[`Page Check page to verify skip to content points to main content region Section with default background
Section with light background
Section with dark background
Section with darker background
@@ -1422,17 +1422,17 @@ exports[`Page Check page vertical layout example against snapshot 1`] = ` Section with default background
Section with light background
Section with dark background
Section with darker background
@@ -1586,17 +1586,17 @@ exports[`Page Sticky bottom breadcrumb on all height breakpoints - PageBreadcrum Section with default background
Section with light background
Section with dark background
Section with darker background
@@ -1750,17 +1750,17 @@ exports[`Page Verify sticky bottom breadcrumb on all height breakpoints 1`] = ` Section with default background
Section with light background
Section with dark background
Section with darker background
@@ -1914,17 +1914,17 @@ exports[`Page Verify sticky top breadcrumb on all height breakpoints - PageBread Section with default background
Section with light background
Section with dark background
Section with darker background
@@ -2078,17 +2078,17 @@ exports[`Page Verify sticky top breadcrumb on all height breakpoints 1`] = ` Section with default background
Section with light background
Section with dark background
Section with darker background
diff --git a/packages/react-core/src/components/Page/examples/PageGroupSection.tsx b/packages/react-core/src/components/Page/examples/PageGroupSection.tsx index 9256bbceea2..2aac5d0c8b7 100644 --- a/packages/react-core/src/components/Page/examples/PageGroupSection.tsx +++ b/packages/react-core/src/components/Page/examples/PageGroupSection.tsx @@ -12,7 +12,6 @@ import { PageGroup, PageBreadcrumb, PageNavigation, - PageSectionVariants, PageToggleButton, Breadcrumb, BreadcrumbItem, @@ -102,10 +101,10 @@ export const PageGroupSection: React.FunctionComponent = () => { - Grouped section + Grouped section - Section 1 - Section 2 + Section 1 + Section 2 ); }; diff --git a/packages/react-core/src/components/Page/examples/PageHorizontalNav.tsx b/packages/react-core/src/components/Page/examples/PageHorizontalNav.tsx index d252e937f01..b3c26ba24cc 100644 --- a/packages/react-core/src/components/Page/examples/PageHorizontalNav.tsx +++ b/packages/react-core/src/components/Page/examples/PageHorizontalNav.tsx @@ -6,7 +6,6 @@ import { MastheadBrand, MastheadContent, PageSection, - PageSectionVariants, Toolbar, ToolbarContent, ToolbarItem @@ -35,9 +34,9 @@ export const PageHorizontalNav: React.FunctionComponent = () => { return ( - Section with darker background - Section with dark background - Section with light background + Section 1 + Section 2 + Section 3 ); }; diff --git a/packages/react-core/src/components/Page/examples/PageMainSectionPadding.tsx b/packages/react-core/src/components/Page/examples/PageMainSectionPadding.tsx index 72372668cf9..cc2d3cdfcb9 100644 --- a/packages/react-core/src/components/Page/examples/PageMainSectionPadding.tsx +++ b/packages/react-core/src/components/Page/examples/PageMainSectionPadding.tsx @@ -9,7 +9,6 @@ import { PageSidebar, PageSidebarBody, PageSection, - PageSectionVariants, PageToggleButton, Toolbar, ToolbarContent, @@ -63,13 +62,9 @@ export const PageMainSectionPadding: React.FunctionComponent = () => { return ( Section with default padding - - Section with no padding - + Section with no padding Section with padding on medium - - Section with no padding on medium - + Section with no padding on medium ); }; diff --git a/packages/react-core/src/components/Page/examples/PageMultipleSidebarBody.tsx b/packages/react-core/src/components/Page/examples/PageMultipleSidebarBody.tsx index ac2b5ac5162..eacf5f12b53 100644 --- a/packages/react-core/src/components/Page/examples/PageMultipleSidebarBody.tsx +++ b/packages/react-core/src/components/Page/examples/PageMultipleSidebarBody.tsx @@ -9,7 +9,6 @@ import { PageSidebar, PageSidebarBody, PageSection, - PageSectionVariants, PageToggleButton, Toolbar, ToolbarContent, @@ -66,9 +65,9 @@ export const PageMultipleSidebarBody: React.FunctionComponent = () => { return ( - Section with darker background - Section with dark background - Section with light background + Section 1 + Section 2 + Section 3 ); }; diff --git a/packages/react-core/src/components/Page/examples/PageTertiaryNav.tsx b/packages/react-core/src/components/Page/examples/PageTertiaryNav.tsx index b5a11180563..2795e8f9da4 100644 --- a/packages/react-core/src/components/Page/examples/PageTertiaryNav.tsx +++ b/packages/react-core/src/components/Page/examples/PageTertiaryNav.tsx @@ -6,7 +6,6 @@ import { MastheadBrand, MastheadContent, PageSection, - PageSectionVariants, Toolbar, ToolbarContent, ToolbarItem @@ -34,9 +33,9 @@ export const PageTertiaryNav: React.FunctionComponent = () => { return ( - Section with darker background - Section with dark background - Section with light background + Section 1 + Section 2 + Section 3 ); }; diff --git a/packages/react-core/src/components/Page/examples/PageUncontrolledNav.tsx b/packages/react-core/src/components/Page/examples/PageUncontrolledNav.tsx index fbd539b1685..4357d19b541 100644 --- a/packages/react-core/src/components/Page/examples/PageUncontrolledNav.tsx +++ b/packages/react-core/src/components/Page/examples/PageUncontrolledNav.tsx @@ -9,7 +9,6 @@ import { PageSidebar, PageSidebarBody, PageSection, - PageSectionVariants, PageToggleButton, Toolbar, ToolbarContent, @@ -50,9 +49,9 @@ export const PageUncontrolledNav: React.FunctionComponent = () => { return ( - Section with darker background - Section with dark background - Section with light background + Section 1 + Section 2 + Section 3 ); }; diff --git a/packages/react-core/src/components/Page/examples/PageVerticalNav.tsx b/packages/react-core/src/components/Page/examples/PageVerticalNav.tsx index fb699c4dd27..a1248de01c1 100644 --- a/packages/react-core/src/components/Page/examples/PageVerticalNav.tsx +++ b/packages/react-core/src/components/Page/examples/PageVerticalNav.tsx @@ -9,7 +9,6 @@ import { PageSidebar, PageSidebarBody, PageSection, - PageSectionVariants, PageToggleButton, Toolbar, ToolbarContent, @@ -62,9 +61,9 @@ export const PageVerticalNav: React.FunctionComponent = () => { return ( - Section with darker background - Section with dark background - Section with light background + Section 1 + Section 2 + Section 3 ); }; diff --git a/packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerGrouped.tsx b/packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerGrouped.tsx index e1bf93e05c9..34377b28e49 100644 --- a/packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerGrouped.tsx +++ b/packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerGrouped.tsx @@ -33,7 +33,6 @@ import { NotificationDrawerListItemHeader, Page, PageSection, - PageSectionVariants, PageSidebar, PageSidebarBody, SkipToContent, @@ -780,7 +779,7 @@ export const NotificationDrawerGrouped: React.FunctionComponent = () => { breadcrumb={PageBreadcrumb} mainContainerId={pageId} > - + Main title @@ -789,7 +788,7 @@ export const NotificationDrawerGrouped: React.FunctionComponent = () => { - Panel section content + Panel section content ); diff --git a/packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx b/packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx index eac1d3ac227..5e2d2f669c2 100644 --- a/packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx +++ b/packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx @@ -31,7 +31,6 @@ import { NavList, Page, PageSection, - PageSectionVariants, PageSidebar, PageSidebarBody, PageToggleButton, @@ -533,7 +532,7 @@ export const MastheadWithUtilitiesAndUserDropdownMenu: React.FunctionComponent = isTertiaryNavGrouped isBreadcrumbGrouped additionalGroupedContent={ - + Main title This is a full page demo. diff --git a/packages/react-core/src/demos/examples/Page/PageStickySectionBreadcrumb.tsx b/packages/react-core/src/demos/examples/Page/PageStickySectionBreadcrumb.tsx index 183ad9c1834..a8063d08d3e 100644 --- a/packages/react-core/src/demos/examples/Page/PageStickySectionBreadcrumb.tsx +++ b/packages/react-core/src/demos/examples/Page/PageStickySectionBreadcrumb.tsx @@ -27,7 +27,6 @@ import { NavList, Page, PageSection, - PageSectionVariants, PageSidebar, PageSidebarBody, PageToggleButton, @@ -270,7 +269,7 @@ export const PageStickySectionBreadcrumb: React.FunctionComponent = () => { } }} > - + Main title This is a full page demo. diff --git a/packages/react-core/src/deprecated/components/PageHeader/examples/PageVerticalNavUsingPageHeaderComponent.tsx b/packages/react-core/src/deprecated/components/PageHeader/examples/PageVerticalNavUsingPageHeaderComponent.tsx index d6a9ef284c4..5b372f6c9fc 100644 --- a/packages/react-core/src/deprecated/components/PageHeader/examples/PageVerticalNavUsingPageHeaderComponent.tsx +++ b/packages/react-core/src/deprecated/components/PageHeader/examples/PageVerticalNavUsingPageHeaderComponent.tsx @@ -1,5 +1,5 @@ import React from 'react'; -import { Page, PageSidebar, PageSidebarBody, PageSection, PageSectionVariants } from '@patternfly/react-core'; +import { Page, PageSidebar, PageSidebarBody, PageSection } from '@patternfly/react-core'; import { PageHeader as PageHeaderDeprecated, PageHeaderTools } from '@patternfly/react-core/deprecated'; export const PageVerticalNavUsingPageHeaderComponent: React.FunctionComponent = () => { @@ -34,9 +34,9 @@ export const PageVerticalNavUsingPageHeaderComponent: React.FunctionComponent = return ( - Section with darker background - Section with dark background - Section with light background + Section 1 + Section 2 + Section 3 ); }; diff --git a/packages/react-core/src/deprecated/components/PageHeader/tests/PageHeaderToolsItem.test.tsx b/packages/react-core/src/deprecated/components/PageHeader/tests/PageHeaderToolsItem.test.tsx index 9010c9c1be5..0c359d7e24d 100644 --- a/packages/react-core/src/deprecated/components/PageHeader/tests/PageHeaderToolsItem.test.tsx +++ b/packages/react-core/src/deprecated/components/PageHeader/tests/PageHeaderToolsItem.test.tsx @@ -9,9 +9,7 @@ import {} from '../..'; it('PageHeaderToolsItem should match snapshot (auto-generated)', () => { const { asFragment } = render( - - children={
ReactNode
} -
+ children={
ReactNode
}
); expect(asFragment()).toMatchSnapshot(); }); diff --git a/packages/react-core/src/deprecated/components/PageHeader/tests/__snapshots__/PageHeaderToolsItem.test.tsx.snap b/packages/react-core/src/deprecated/components/PageHeader/tests/__snapshots__/PageHeaderToolsItem.test.tsx.snap index a8abc7f5f07..5d704dab277 100644 --- a/packages/react-core/src/deprecated/components/PageHeader/tests/__snapshots__/PageHeaderToolsItem.test.tsx.snap +++ b/packages/react-core/src/deprecated/components/PageHeader/tests/__snapshots__/PageHeaderToolsItem.test.tsx.snap @@ -3,7 +3,7 @@ exports[`PageHeaderToolsItem should match snapshot (auto-generated) 1`] = `
children=
diff --git a/packages/react-integration/cypress/integration/page.spec.ts b/packages/react-integration/cypress/integration/page.spec.ts index fe6c5488765..7c3682b5b85 100644 --- a/packages/react-integration/cypress/integration/page.spec.ts +++ b/packages/react-integration/cypress/integration/page.spec.ts @@ -15,8 +15,6 @@ describe('Page Demo Test', () => { cy.get('#page-demo-header').should('not.have.attr', 'role'); cy.get('#page-demo-page-id').should('not.have.attr', 'role'); cy.get('div[class="pf-v5-c-page__header-brand-link"]').invoke('text').should('eq', "Logo that's a
"); - cy.get('.pf-v5-c-page__main-section.pf-m-dark-100').should('exist'); - cy.get('.pf-v5-c-page__main-section.pf-m-dark-200').should('exist'); cy.get('.pf-v5-c-page__main-section.pf-m-light').should('exist'); cy.get('.pf-v5-c-page__main-section.pf-m-no-padding').should('exist'); cy.get('.pf-v5-c-page__main-section.pf-m-no-padding-on-md').should('exist'); diff --git a/packages/react-integration/cypress/integration/pagemanagedsidebarclosed.spec.ts b/packages/react-integration/cypress/integration/pagemanagedsidebarclosed.spec.ts index bb2c555676e..ec26152506d 100644 --- a/packages/react-integration/cypress/integration/pagemanagedsidebarclosed.spec.ts +++ b/packages/react-integration/cypress/integration/pagemanagedsidebarclosed.spec.ts @@ -14,8 +14,6 @@ describe('Page Managed Sidebar Closed Demo Test', () => { }); cy.get('div[class="pf-v5-c-masthead__brand"]').invoke('text').should('eq', "Logo that's a div"); cy.get('.pf-v5-c-masthead__content').invoke('text').should('contain', 'header-tools | Avatar'); - cy.get('.pf-v5-c-page__main-section.pf-m-dark-100').should('exist'); - cy.get('.pf-v5-c-page__main-section.pf-m-dark-200').should('exist'); cy.get('.pf-v5-c-page__main-section.pf-m-light').should('exist'); }); }); diff --git a/packages/react-integration/demo-app-ts/src/components/demos/BackToTopDemo/BackToTopDemo.tsx b/packages/react-integration/demo-app-ts/src/components/demos/BackToTopDemo/BackToTopDemo.tsx index 71fbc88b94f..1625932fcd8 100644 --- a/packages/react-integration/demo-app-ts/src/components/demos/BackToTopDemo/BackToTopDemo.tsx +++ b/packages/react-integration/demo-app-ts/src/components/demos/BackToTopDemo/BackToTopDemo.tsx @@ -6,7 +6,6 @@ import { Gallery, GalleryItem, PageSection, - PageSectionVariants, TextContent, Text, Page @@ -14,7 +13,7 @@ import { export const BackToTopDemo = () => ( - + Main title diff --git a/packages/react-integration/demo-app-ts/src/components/demos/PageDemo/PageDemo.tsx b/packages/react-integration/demo-app-ts/src/components/demos/PageDemo/PageDemo.tsx index 79de679b844..ef1dff63d2b 100644 --- a/packages/react-integration/demo-app-ts/src/components/demos/PageDemo/PageDemo.tsx +++ b/packages/react-integration/demo-app-ts/src/components/demos/PageDemo/PageDemo.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import React, { Component } from 'react'; import { Avatar, Button, @@ -6,7 +6,6 @@ import { PageSidebar, PageSidebarBody, PageSection, - PageSectionVariants, SkipToContent, Dropdown, DropdownItem, @@ -25,7 +24,7 @@ import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question- import imgAvatar from '@patternfly/react-integration/demo-app-ts/src/assets/images/imgAvatar.svg'; import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; -export class PageDemo extends React.Component { +export class PageDemo extends Component { static displayName = 'PageDemo'; state = { isNavOpen: true, @@ -125,9 +124,9 @@ export class PageDemo extends React.Component { this.setState({ isKebabDropdownOpen: isOpen })} + onOpenChange={(isOpen: any) => this.setState({ isKebabDropdownOpen: isOpen })} popperProps={{ position: 'right' }} - toggle={(toggleRef) => ( + toggle={(toggleRef: any) => ( this.setState({ isDropdownOpen: isOpen })} + onOpenChange={(isOpen: any) => this.setState({ isDropdownOpen: isOpen })} popperProps={{ position: 'right' }} - toggle={(toggleRef) => ( + toggle={(toggleRef: any) => ( John Smith @@ -201,11 +200,9 @@ export class PageDemo extends React.Component { skipToContent={PageSkipToContent} mainAriaLabel="page demo" > - Section with darker background - Section with dark background - - Section with light background - + Section 1 + Section 2 + Section 3 Section with padding only on medium/large - - Section with no padding on medium - + Section with no padding on medium ); } diff --git a/packages/react-integration/demo-app-ts/src/components/demos/PageDemo/PageManagedSidebarClosedDemo.tsx b/packages/react-integration/demo-app-ts/src/components/demos/PageDemo/PageManagedSidebarClosedDemo.tsx index 742fc3bb257..606fb4db097 100644 --- a/packages/react-integration/demo-app-ts/src/components/demos/PageDemo/PageManagedSidebarClosedDemo.tsx +++ b/packages/react-integration/demo-app-ts/src/components/demos/PageDemo/PageManagedSidebarClosedDemo.tsx @@ -9,7 +9,6 @@ import { PageSidebar, PageSidebarBody, PageSection, - PageSectionVariants, PageToggleButton, Toolbar, ToolbarContent, @@ -48,9 +47,7 @@ export const PageManagedSidebarClosedDemo: React.FunctionComponent = () => { return ( - Section with darker background - Section with dark background - Section with light background + Section ); }; From 7db314fd770bdf33a7da4cf425f115c12cf234cc Mon Sep 17 00:00:00 2001 From: Titani Date: Wed, 1 Nov 2023 13:29:17 -0400 Subject: [PATCH 07/12] update snapshots --- .../__tests__/__snapshots__/SearchInput.test.tsx.snap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap b/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap index 24719463b95..bd29a38c8f3 100644 --- a/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap +++ b/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap @@ -293,7 +293,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = ` data-popper-escaped="true" data-popper-placement="bottom-start" data-popper-reference-hidden="true" - style="position: absolute; top: 0px; left: 0px; transform: translate(0px, 0px); min-width: 0px; z-index: 9999; opacity: 1; transition: opacity 0ms cubic-bezier(.54, 1.5, .38, 1.11);" + style="position: absolute; top: 0px; left: 0px; transform: translate(0px, 0px); min-width: 0px; z-index: 9999; opacity: 0; transition: opacity 0ms cubic-bezier(.54, 1.5, .38, 1.11);" >
Date: Wed, 1 Nov 2023 14:40:26 -0400 Subject: [PATCH 08/12] remove Page setion variants that are no longer needed and update snapshots --- .../components/Page/__tests__/Page.test.tsx | 39 ---- .../__snapshots__/Page.test.tsx.snap | 195 ----------------- .../__snapshots__/SearchInput.test.tsx.snap | 2 +- packages/react-core/src/demos/Banner.md | 6 +- .../src/demos/CardView/examples/CardView.tsx | 10 +- packages/react-core/src/demos/JumpLinks.md | 2 +- .../examples/NotificationDrawerBasic.tsx | 5 +- .../react-core/src/demos/PrimaryDetail.md | 11 +- packages/react-core/src/demos/Tabs.md | 14 +- .../react-core/src/demos/Wizard/WizardDemo.md | 200 ++++++++++++++++++ .../AlertGroupToastWithNotificationDrawer.tsx | 9 +- .../examples/BackToTop/BackToTopNameDemo.tsx | 3 +- .../src/demos/examples/DashboardWrapper.js | 127 +++++++++++ .../examples/JumpLinks/JumpLinksWithDrawer.js | 7 +- .../examples/Page/PageStickySectionGroup.tsx | 3 +- .../Page/PageStickySectionGroupAlternate.tsx | 3 +- .../PrimaryDetailContentPadding.tsx | 3 +- .../PrimaryDetail/PrimaryDetailFullPage.tsx | 5 +- .../PrimaryDetailInlineModifier.tsx | 5 +- .../src/demos/examples/Tabs/ModalTabs.tsx | 3 +- .../examples/Tabs/NestedUnindentedTabs.tsx | 4 +- .../src/demos/examples/Tabs/TabsAndTable.tsx | 5 +- .../react-docs/patternfly-docs/pages/icons.js | 2 +- .../react-docs/patternfly-docs/pages/index.js | 2 +- .../cypress/integration/page.spec.ts | 1 - .../pagemanagedsidebarclosed.spec.ts | 1 - packages/react-table/src/docs/demos/Table.md | 1 - .../demos/table-demos/SortableResponsive.jsx | 3 +- 28 files changed, 368 insertions(+), 303 deletions(-) create mode 100644 packages/react-core/src/demos/examples/DashboardWrapper.js diff --git a/packages/react-core/src/components/Page/__tests__/Page.test.tsx b/packages/react-core/src/components/Page/__tests__/Page.test.tsx index 537f453438e..761f5fe8d2c 100644 --- a/packages/react-core/src/components/Page/__tests__/Page.test.tsx +++ b/packages/react-core/src/components/Page/__tests__/Page.test.tsx @@ -32,9 +32,6 @@ describe('Page', () => { const { asFragment } = render( Section with default background - Section with light background - Section with dark background - Section with darker background ); @@ -52,9 +49,6 @@ describe('Page', () => { const { asFragment } = render( Section with default background - Section with light background - Section with dark background - Section with darker background ); @@ -68,9 +62,6 @@ describe('Page', () => { const { asFragment } = render( Section with default background - Section with light background - Section with dark background - Section with darker background ); @@ -94,9 +85,6 @@ describe('Page', () => { const { asFragment } = render( }> Section with default background - Section with light background - Section with dark background - Section with darker background ); @@ -127,9 +115,6 @@ describe('Page', () => { breadcrumbProps={{ stickyOnBreakpoint: { sm: 'top', md: 'top', lg: 'top', xl: 'top', '2xl': 'top' } }} > Section with default background - Section with light background - Section with dark background - Section with darker background ); @@ -162,9 +147,6 @@ describe('Page', () => { }} > Section with default background - Section with light background - Section with dark background - Section with darker background ); @@ -189,9 +171,6 @@ describe('Page', () => { Section with default background - Section with light background - Section with dark background - Section with darker background ); @@ -216,9 +195,6 @@ describe('Page', () => { Section with default background - Section with light background - Section with dark background - Section with darker background ); @@ -245,9 +221,6 @@ describe('Page', () => { Section with default background - Section with light background - Section with dark background - Section with darker background ); @@ -275,9 +248,6 @@ describe('Page', () => { Section with default background - Section with light background - Section with dark background - Section with darker background ); @@ -317,9 +287,6 @@ describe('Page', () => { Section with default background - Section with light background - Section with dark background - Section with darker background ); @@ -373,9 +340,6 @@ describe('Page', () => { }} > Section with default background - Section with light background - Section with dark background - Section with darker background ); @@ -411,9 +375,6 @@ describe('Page', () => { data-testid="page-test-id" > Section with default background - Section with light background - Section with dark background - Section with darker background ); diff --git a/packages/react-core/src/components/Page/__tests__/__snapshots__/Page.test.tsx.snap b/packages/react-core/src/components/Page/__tests__/__snapshots__/Page.test.tsx.snap index a1f5a60f8bd..6b5798ff1ca 100644 --- a/packages/react-core/src/components/Page/__tests__/__snapshots__/Page.test.tsx.snap +++ b/packages/react-core/src/components/Page/__tests__/__snapshots__/Page.test.tsx.snap @@ -41,21 +41,6 @@ exports[`Page Check dark page against snapshot 1`] = ` > Section with default background -
- Section with light background -
-
- Section with dark background -
-
- Section with darker background -
@@ -101,21 +86,6 @@ exports[`Page Check page horizontal layout example against snapshot 1`] = ` > Section with default background -
- Section with light background -
-
- Section with dark background -
-
- Section with darker background -
@@ -265,21 +235,6 @@ exports[`Page Check page to verify breadcrumb is created - PageBreadcrumb syntax > Section with default background -
- Section with light background -
-
- Section with dark background -
-
- Section with darker background -
@@ -429,21 +384,6 @@ exports[`Page Check page to verify breadcrumb is created 1`] = ` > Section with default background -
- Section with light background -
-
- Section with dark background -
-
- Section with darker background -
@@ -713,21 +653,6 @@ exports[`Page Check page to verify grouped nav and breadcrumb - new components s > Section with default background -
- Section with light background -
-
- Section with dark background -
-
- Section with darker background -
@@ -1004,21 +929,6 @@ exports[`Page Check page to verify grouped nav and breadcrumb - old / props synt > Section with default background -
- Section with light background -
-
- Section with dark background -
-
- Section with darker background -
@@ -1180,21 +1090,6 @@ exports[`Page Check page to verify nav is created - PageNavigation syntax 1`] = > Section with default background -
- Section with light background -
-
- Section with dark background -
-
- Section with darker background -
@@ -1360,21 +1255,6 @@ exports[`Page Check page to verify skip to content points to main content region > Section with default background -
- Section with light background -
-
- Section with dark background -
-
- Section with darker background -
@@ -1421,21 +1301,6 @@ exports[`Page Check page vertical layout example against snapshot 1`] = ` > Section with default background -
- Section with light background -
-
- Section with dark background -
-
- Section with darker background -
@@ -1585,21 +1450,6 @@ exports[`Page Sticky bottom breadcrumb on all height breakpoints - PageBreadcrum > Section with default background -
- Section with light background -
-
- Section with dark background -
-
- Section with darker background -
@@ -1749,21 +1599,6 @@ exports[`Page Verify sticky bottom breadcrumb on all height breakpoints 1`] = ` > Section with default background -
- Section with light background -
-
- Section with dark background -
-
- Section with darker background -
@@ -1913,21 +1748,6 @@ exports[`Page Verify sticky top breadcrumb on all height breakpoints - PageBread > Section with default background -
- Section with light background -
-
- Section with dark background -
-
- Section with darker background -
@@ -2077,21 +1897,6 @@ exports[`Page Verify sticky top breadcrumb on all height breakpoints 1`] = ` > Section with default background -
- Section with light background -
-
- Section with dark background -
-
- Section with darker background -
diff --git a/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap b/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap index bd29a38c8f3..24719463b95 100644 --- a/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap +++ b/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap @@ -293,7 +293,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = ` data-popper-escaped="true" data-popper-placement="bottom-start" data-popper-reference-hidden="true" - style="position: absolute; top: 0px; left: 0px; transform: translate(0px, 0px); min-width: 0px; z-index: 9999; opacity: 0; transition: opacity 0ms cubic-bezier(.54, 1.5, .38, 1.11);" + style="position: absolute; top: 0px; left: 0px; transform: translate(0px, 0px); min-width: 0px; z-index: 9999; opacity: 1; transition: opacity 0ms cubic-bezier(.54, 1.5, .38, 1.11);" >
Ned Username
- + Main title @@ -87,7 +86,6 @@ import { Gallery, GalleryItem, PageSection, - PageSectionVariants, TextContent, Text } from '@patternfly/react-core'; @@ -122,7 +120,7 @@ class BannerDemo extends React.Component { - + Main title diff --git a/packages/react-core/src/demos/CardView/examples/CardView.tsx b/packages/react-core/src/demos/CardView/examples/CardView.tsx index 61eac10e41f..8e6d004f9ef 100644 --- a/packages/react-core/src/demos/CardView/examples/CardView.tsx +++ b/packages/react-core/src/demos/CardView/examples/CardView.tsx @@ -25,7 +25,6 @@ import { OverflowMenuDropdownItem, OverflowMenuItem, PageSection, - PageSectionVariants, Pagination, TextContent, Text, @@ -472,7 +471,7 @@ export const CardViewBasic: React.FunctionComponent = () => { return ( - + Projects This is a demo that showcases PatternFly cards. @@ -554,12 +553,7 @@ export const CardViewBasic: React.FunctionComponent = () => { ))} - + { return ( - + Main title diff --git a/packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerBasic.tsx b/packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerBasic.tsx index 721e40cdb1f..c421679018c 100644 --- a/packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerBasic.tsx +++ b/packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerBasic.tsx @@ -31,7 +31,6 @@ import { NotificationDrawerListItemHeader, Page, PageSection, - PageSectionVariants, PageSidebar, PageSidebarBody, SkipToContent, @@ -541,7 +540,7 @@ export const NotificationDrawerBasic: React.FunctionComponent = () => { breadcrumb={PageBreadcrumb} mainContainerId={pageId} > - + Main title @@ -550,7 +549,7 @@ export const NotificationDrawerBasic: React.FunctionComponent = () => { - Panel section content + Panel section content ); diff --git a/packages/react-core/src/demos/PrimaryDetail.md b/packages/react-core/src/demos/PrimaryDetail.md index 732b5c4e3f0..df8f6489d1c 100644 --- a/packages/react-core/src/demos/PrimaryDetail.md +++ b/packages/react-core/src/demos/PrimaryDetail.md @@ -66,7 +66,6 @@ import { MenuToggle, MenuToggleCheckbox, PageSection, - PageSectionVariants, Pagination, Progress, TextContent, @@ -597,7 +596,7 @@ class PrimaryDetailCardView extends React.Component { return ( - + Projects This is a demo that showcases Patternfly Cards. @@ -616,7 +615,7 @@ class PrimaryDetailCardView extends React.Component { - + - + Main title @@ -817,7 +815,6 @@ import { FlexItem, MenuToggle, PageSection, - PageSectionVariants, Progress, Text, TextContent, @@ -1000,7 +997,7 @@ class PrimaryDetailDataListInCard extends React.Component { return ( - + Main title diff --git a/packages/react-core/src/demos/Tabs.md b/packages/react-core/src/demos/Tabs.md index dff0305efec..613c17a0ffd 100644 --- a/packages/react-core/src/demos/Tabs.md +++ b/packages/react-core/src/demos/Tabs.md @@ -21,7 +21,6 @@ import spacing from '@patternfly/react-styles/css/utilities/Spacing/spacing'; import React from 'react'; import { PageSection, - PageSectionVariants, PageBreadcrumb, Breadcrumb, BreadcrumbItem, @@ -157,7 +156,7 @@ TabsOpenDemo = () => { return ( {tabsBreadcrumb} - + { - + Details} tabContentId={`tabContent${0}`} /> YAML} tabContentId={`tabContent${1}`} /> @@ -185,7 +184,7 @@ TabsOpenDemo = () => { Terminal} tabContentId={`tabContent${4}`} /> - + @@ -213,7 +212,6 @@ TabsOpenDemo = () => { import React from 'react'; import { PageSection, - PageSectionVariants, PageBreadcrumb, Breadcrumb, BreadcrumbItem, @@ -354,7 +352,7 @@ TabsOpenWithSecondaryTabsDemo = () => { return ( {tabsBreadcrumb} - + { - + Details} tabContentId={`tabContent${0}`} /> YAML} tabContentId={`tabContent${1}`} /> @@ -382,7 +380,7 @@ TabsOpenWithSecondaryTabsDemo = () => { Terminal} tabContentId={`tabContent${4}`} /> - +