Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024b update #48

Open
ertankucukoglu opened this issue Dec 14, 2024 · 4 comments
Open

2024b update #48

ertankucukoglu opened this issue Dec 14, 2024 · 4 comments

Comments

@ertankucukoglu
Copy link

Hello,

Is it possible to update to the 2024b update (2024-09-04)?

Thanks & Regards,
Ertan

@pavkam
Copy link
Owner

pavkam commented Dec 18, 2024

Hello,

Is it possible to update to the 2024b update (2024-09-04)?

Thanks & Regards,

Ertan

Need to fix an issue in the converter. Seems like there's additional syntax in the new files.

@ertankucukoglu
Copy link
Author

I asked IANA if this is an error or not April written in full name in northamerica file for Maxico.

@ertankucukoglu
Copy link
Author

IANA reply is as below

> I wonder if that is the new format and not an error.

It's not a new format and is not an error; full month names like "April"
have been documented for decades and have worked in zic.

That being said, some other converters didn't grok "April" so it's
planned to be changed to "Apr" in the next release.

Even if is planned to be changed for next release, it would be good to support full Month names for TZDB parser.

I will try to work on the parser to see if I can modify it.

@ertankucukoglu
Copy link
Author

ertankucukoglu commented Jan 8, 2025

Need to fix an issue in the converter. Seems like there's additional syntax in the new files.

I am not good at Git usage. Below two modifications helps to parse v2024b update.

TZStrs.pas: 43 (add below)

  CAbbFullMonthNames: array[1..12] of string = (
    'January', 'February', 'March', 'April', 'May', 'June', 'July', 'August', 'Septempber', 'October', 'November', 'December');

TZSchema.pas: 371 (add below)

  for Result := Low(CAbbFullMonthNames) to High(CAbbFullMonthNames) do
    if SameText(CAbbFullMonthNames[Result], Abb) then
      Exit;

However, TZTest still lists 6 failures as below:

Compiling ./src/TZDBLIB/TZCAPI.pas
Linking bin/TZTest
15216 lines compiled, 0.4 sec
56 warning(s) issued
58 note(s) issued
..........F.FF................FFF......................................................... Time:00.052 N:90 E:0 F:6 I:0
  TTZDBTest Time:00.049 N:38 E:0 F:6 I:0
    00.000  Test_TZ_GetYearBreakdown_Sao_Paulo_2014  Failed: "" expected: <-02> but was: <%z>
      Exception:   "" expected: <-02> but was: <%z>
      at   $0000000000429CF0
    00.000  Test_TZ_GetYearBreakdown_Apia_2010  Failed: "" expected: <-11> but was: <%z>
      Exception:   "" expected: <-11> but was: <%z>
      at   $0000000000429CF0
    00.000  Test_TZ_GetYearBreakdown_Apia_2011  Failed: "" expected: <-10> but was: <%z>
      Exception:   "" expected: <-10> but was: <%z>
      at   $0000000000429CF0
    00.005  Test_America_Araguaina_1950  Failed: "DST name differs for 0 period." expected: <-02> but was: <%z>
      Exception:   "DST name differs for 0 period." expected: <-02> but was: <%z>
      at   $0000000000433FFA
    00.004  Test_Etc_GTM12_2010  Failed: "DST name differs for 0 period." expected: <-12> but was: <%z>
      Exception:   "DST name differs for 0 period." expected: <-12> but was: <%z>
      at   $00000000004340FA
    00.003  Test_Etc_GTMMin9_1991  Failed: "DST name differs for 0 period." expected: <+09> but was: <%z>
      Exception:   "DST name differs for 0 period." expected: <+09> but was: <%z>
      at   $000000000043413A
  TTZDB_St_Johns_2018_Test Time:00.001 N:13 E:0 F:0 I:0
  TTZDB_London_2018_Test Time:00.001 N:13 E:0 F:0 I:0
  TTZDB_Canberra_2018_Test Time:00.000 N:13 E:0 F:0 I:0
  TTZDB_NewYork_2018_Test Time:00.001 N:13 E:0 F:0 I:0

Number of run tests: 90
Number of errors:    0
Number of failures:  6

List of failures:
  Failure: 
    Message:           TTZDBTest.Test_TZ_GetYearBreakdown_Sao_Paulo_2014: "" expected: <-02> but was: <%z>
    Exception class:   EAssertionFailedError
        at   $0000000000429CF0
  Failure: 
    Message:           TTZDBTest.Test_TZ_GetYearBreakdown_Apia_2010: "" expected: <-11> but was: <%z>
    Exception class:   EAssertionFailedError
        at   $0000000000429CF0
  Failure: 
    Message:           TTZDBTest.Test_TZ_GetYearBreakdown_Apia_2011: "" expected: <-10> but was: <%z>
    Exception class:   EAssertionFailedError
        at   $0000000000429CF0
  Failure: 
    Message:           TTZDBTest.Test_America_Araguaina_1950: "DST name differs for 0 period." expected: <-02> but was: <%z>
    Exception class:   EAssertionFailedError
        at   $0000000000433FFA
  Failure: 
    Message:           TTZDBTest.Test_Etc_GTM12_2010: "DST name differs for 0 period." expected: <-12> but was: <%z>
    Exception class:   EAssertionFailedError
        at   $00000000004340FA
  Failure: 
    Message:           TTZDBTest.Test_Etc_GTMMin9_1991: "DST name differs for 0 period." expected: <+09> but was: <%z>
    Exception class:   EAssertionFailedError
        at   $000000000043413A




[ERR] Tests failed! Please correct the errors before continuing.

I don't know if source need more modifications. Would you check this out, please?

Thanks & Regards,
Ertan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants