Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website docs - Markdown to HTML produces abrupt line breaks #10387

Open
bratvanov opened this issue Jan 6, 2025 · 0 comments · Fixed by #10424
Open

Website docs - Markdown to HTML produces abrupt line breaks #10387

bratvanov opened this issue Jan 6, 2025 · 0 comments · Fixed by #10424
Assignees
Labels
created-by: Contributor documentation Improvements or additions to documentation plugin: richtext-lexical @payloadcms/richtext-lexical prioritized status: needs-triage Possible bug which hasn't been reproduced yet

Comments

@bratvanov
Copy link
Contributor

Documentation Issue

Line breaks in the raw Markdown files render abrupt <br> tags on Payload docs website.

Some examples:

Image

The GitHub Markdown preview handles these line breaks okay without rendering them.

Image

Additional Details

My first instinct was to track down all of these line breaks in the .mdx files and simply create a PR that removes them. However, preserving the line breaks could be good for the readability of the raw Markdown.

The alternative would be to adjust the Markdown to HTML conversion on the Payload docs website to take this into account and match GitHub's rendering of line breaks.

@bratvanov bratvanov added the documentation Improvements or additions to documentation label Jan 6, 2025
@bratvanov bratvanov changed the title Payload website docs - Markdown to HTML produces abrupt line breaks Website docs - Markdown to HTML produces abrupt line breaks Jan 6, 2025
@AlessioGr AlessioGr assigned GermanJablo and unassigned AlessioGr Jan 6, 2025
@AlessioGr AlessioGr added plugin: richtext-lexical @payloadcms/richtext-lexical prioritized labels Jan 6, 2025
GermanJablo added a commit that referenced this issue Jan 7, 2025
Fix #10387

The default argument was true and then in the nested function false.
@GermanJablo GermanJablo reopened this Jan 7, 2025
@github-actions github-actions bot added the status: needs-triage Possible bug which hasn't been reproduced yet label Jan 7, 2025
@payloadcms payloadcms deleted a comment from github-actions bot Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Contributor documentation Improvements or additions to documentation plugin: richtext-lexical @payloadcms/richtext-lexical prioritized status: needs-triage Possible bug which hasn't been reproduced yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants