Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: calculate Mykobo fee correctly #118

Closed
TorstenStueber opened this issue Aug 26, 2024 · 2 comments · Fixed by #121
Closed

Bugfix: calculate Mykobo fee correctly #118

TorstenStueber opened this issue Aug 26, 2024 · 2 comments · Fixed by #121
Assignees
Labels
type:bug Something isn't working

Comments

@TorstenStueber
Copy link
Collaborator

Currently we define a 5% fee for Mykobo in order to calculate the final amount the user will receive. This is incorrect.

TODO

  • the actual fee is 1.25% instead
  • currently the absolute fee is calculated by rounding down, instead it needs to be rounded to the closest cent value (e.g., the fee for an input value of 1000.4 is 12.51, not 12.5).
@TorstenStueber TorstenStueber added the type:bug Something isn't working label Aug 26, 2024
@TorstenStueber TorstenStueber self-assigned this Aug 26, 2024
@TorstenStueber TorstenStueber linked a pull request Aug 26, 2024 that will close this issue
@vadaynujra
Copy link

@TorstenStueber For the implementation of this fix, we should do it in a way that is not fixed for all off ramping currencies but different for each as each anchor that is off ramping the asset is expected to have a different fee.

@TorstenStueber
Copy link
Collaborator Author

The fee is not hardcoded but defined by anchor asset.

For other anchors we might need to extend the fee calculation as they might use a combination of fixed and relative fees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants