Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Shared/Critical In-Memory Logic #56

Open
dmtrshat opened this issue Jan 6, 2025 · 0 comments
Open

Integrate Shared/Critical In-Memory Logic #56

dmtrshat opened this issue Jan 6, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@dmtrshat
Copy link
Member

dmtrshat commented Jan 6, 2025

Description

Ensure that shared and critical rules in the new ConfigInMemory are also processed. Similar to how we handle them in the file-based approach:

  • Shared: Combine or minify shared styles.
  • Critical: Combine or handle critical styles (e.g., if there’s a separate injection or special handling logic).

Acceptance Criteria

  1. build_in_memory() (or the relevant method) incorporates config_in_memory.shared and config_in_memory.critical in the same manner as disk-based code does with shared/critical.
  2. The returned data structure includes any generated shared or critical CSS (with an appropriate output_name).
  3. Tests confirm that both shared and critical logic is invoked when the in-memory config has these sections.
@dmtrshat dmtrshat added the enhancement New feature or request label Jan 6, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Grimoire CSS Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant