Add pr_ordata to HERB .rosinstall files`

[mkoval]

@DavidB-CMU pointed out in https://github.com/personalrobotics/pr_docs/issues/2 that none of our HERB .rosinstall files install pr_ordata. We should definitely add this to herb-minimal-remote-op.rosinstall, since these models are required by for prpy perception to work as intended

I am less sure about herb-minimal-sim.rosinstall. On one hand, the models are used in the herbpy TSR library, action library, and example scripts. On the other hand, pr_ordata is a fairly heavyweight dependency that is not strictly required. @jeking04, what do you think?

[psigen]

FWIW, I use herbpy all the time without pr-ordata. I have my own environment models and only need herb_description to run HERB.

I cherish the time I don't spend downloading pr-ordata, and the disk space I don't need, especially since I often install multiple copies of herbpy in VMs or docker images.

[mkoval]

We are not talking about adding pr_ordata as a dependency of herbpy - only to the .rosinstall files in this repository.

[psigen]

Yes, I am using the herb-minimal-sim.rosinstall to install herbpy in the above cases.
I don't see a particular reason why fuze bottles should be considered a minimal simulation component of HERB.

[psigen]

Perhaps a herb-desktop-sim.rosinstall that includes pr_ordata and other utility packages? Clearly you have some average use-case in mind where someone can check out the .rosinstall and drive around grabbing fuze bottles. But that's not really minimal per-se.

[mkoval]

Clearly you have some average use-case in mind where someone can check out the .rosinstall and drive around grabbing fuze bottles.

This is the only example shipped with herbpy, so it sounds pretty minimal to me...

[psigen]

I don't need to run the example? I need to run herbpy console.py --sim

[jeking04]

I usually find myself checking out pr-or data But I can simpithize with
Pras as there are a lot o things that can be done without it, making it not
seem a minimal requirement.

However, for now the data package isn't too big so I would probably vote to
put it in for convenience. As we start to move in more ycb objects, this
package will become more painful to download. We could revisit at that time.

On Sunday, March 27, 2016, Pras Velagapudi notifications@github.com wrote:

I don't need to run the example? I need to run herbpy console.py --sim

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10 (comment)

Jen King