Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

New release compatible with devise 4 #192

Open
mrdomino opened this issue Jul 20, 2016 · 18 comments
Open

New release compatible with devise 4 #192

mrdomino opened this issue Jul 20, 2016 · 18 comments

Comments

@mrdomino
Copy link

0.10.0 requires devise < 4, so it's impossible to use both the latest devise and the latest devise_security_extension. It'd be great to have a release from current master, which doesn't seem to have this problem.

@borisrorsvort
Copy link

@manno any update on this one?

@manno
Copy link
Contributor

manno commented Aug 26, 2016

I'm not using devise_security_extension myself and I don't have access to the rubygems account (#178).
However I do still have commit access, so I could merge a PR to make master work with modern Rails.

Long-term, someone with rubygems access needs to step up or the actual users will have to fork the project. It would really benefit from some active maintainers. That would be a good opportunity to split this into smaller gems, too.

@borisrorsvort
Copy link

@manno tried this one and it seems to work fine #195

@manno
Copy link
Contributor

manno commented Aug 26, 2016

@borisrorsvort #195 is now merged

@mvz
Copy link

mvz commented Nov 21, 2016

@manno what needs to happen for a new gem to be pushed to rubygems?

@khataev
Copy link

khataev commented Dec 2, 2016

+1 for compability with devise 4.0

@ericenns
Copy link

Any update on this I need Devise 4.2 so I can deploy via sub path

@v3rron
Copy link

v3rron commented Jan 14, 2017

Same here, can't install this Gem due to dependency conflict with Devise 4.2.
Please push the update to RubyGems.

@Drenmi
Copy link

Drenmi commented Feb 8, 2017

Phatworx website is no longer available, so is it safe to assume that no-one is maintaining this anymore?

@adamdullenty
Copy link

+1 on not being able to install this due to dependency conflict with Devise 4.2.

@natebird
Copy link
Contributor

natebird commented Mar 1, 2017

I'm not trying to fork or take over the project but if you'd like to use my repo I've updated it for Rails 5 / Devise 4 compatibility.

https://github.com/natebird/devise_security_extension

I also changed the gem tag to 0.10.1 just so I could differentiate versions in my software.

@dillonwelch
Copy link

@natebird FYI I have #216 up if you need Ruby 2.4 support, I can make a PR on your fork too.

@natebird
Copy link
Contributor

natebird commented Apr 5, 2017 via email

@toobulkeh
Copy link

@natebird would you be willing to fork this into a different Gem? even just differently named so we can use rubygems over some kind of git reference would definitely help

@dillonwelch
Copy link

The approach I'd like to see is getting these into the main devise gem

@vinagrito
Copy link

@traxanos

@natebird
Copy link
Contributor

natebird commented Jul 23, 2017

@toobulkeh, @oniofchaos -
I would like to investigate the following solutions:

  • See if @traxanos and other owners are still interested in maintaining this gem. If not then see if we can't get some fresh blood to cleanup and maintain it.
  • It would also be good to investigate the possibility of merging this into the devise gem. I'm not sure the history but I think this gem has many features that can be used by nearly all devise users.
  • If all of this fails then we should just fork this into a new gem so this code can be maintained more regularly. There seems to be at least some interest in keeping this extension going.

@mvz
Copy link

mvz commented Dec 19, 2017

There's a forked gem devise-security: https://github.com/devise-security/devise-security

your added a commit to moneyadviceservice/rad that referenced this issue Jan 8, 2019
This is a required step. Blocked by this extension: phatworx/devise_security_extension#192

Possible solution: forked gem devise-security: https://github.com/devise-security/devise-security
your added a commit to moneyadviceservice/rad that referenced this issue Jan 14, 2019
This is a required step to upgrade Ruby.
Blocked by this extension: phatworx/devise_security_extension#192
Possible solution: forked gem `devise-security`: https://github.com/devise-security/devise-security

Also fixes devise translation in tests:
It's being humanized internally now: heartcombo/devise@b6e4586

Relevant things changed:

`devise`:

* https://github.com/plataformatec/devise/tree/6edbeb82cdaaed8cd6c041ebe7a62534c71fd0e3#strong-parameters

* https://www.rubydoc.info/gems/devise/4.5.0/Devise/Test/ControllerHelpers

`devise-security`:

* devise-security/devise-security@e2f7f8f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests