Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action benchmarking? #162

Open
MGatner opened this issue Dec 6, 2020 · 1 comment
Open

GitHub Action benchmarking? #162

MGatner opened this issue Dec 6, 2020 · 1 comment

Comments

@MGatner
Copy link

MGatner commented Dec 6, 2020

Hello phpbenchmarks! I'm hailing from CodeIgniter 4. Frequently we will have PRs come up (like this and this) that the code will all seem fine but there are larger questions of performance. That got me thinking how I would evaluate a PR to answer the question: "Will this change significantly impact the framework's performance?"

My solution: a GitHub Action that returns a relative benchmark result similar to Code Coverage that could be assessed for "pass" or "failure". I've poked around at benchmarking and found you all, ready to go with your benchmark kit.

My question: Has anyone tried wrapping this kit in a GitHub Action? Would you be willing to work with us on launching a CodeIgniter 4 kit?

@steevanb
Copy link
Member

steevanb commented Dec 7, 2020

Hi!

I have same idea as your ;) For now i don't know if GitHub actions is the right solution: a simple task could take 1 sec as 10 sec... so benchmark results could be not comparable.

For now i'm working on full automation each time a new tag is created on a repository, to generate code and start benchmark.

When it will be finished, I will work on this idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants