-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My attempt to refresh the phpMyAdmin website #176
Comments
Hi @robinheidrich |
@williamdes Sorry for the late reply. I have it on my old computer, but will try to do a PR soon. But it's pretty messed up I think, I went straight to it and didn't do any commits. If it would be better, I can also do PRs with the individual changes. |
Sure, you can open the PRs. And ping me for a review or if I miss the notification |
@williamdes I am currently continuing with the website and am curious: Is “planet.phpmyadmin.net” still being used? It says last updated 2023. I would rather use a CDN for Bootstrap instead of hosting it. But the Planet website would also have to switch to it because it currently uses the static Bootstrap files from the phpMyAdmin website. (And I hope a big commit full of changes isn't too bad, it was just easier this way) And while I'm at it, what about |
Nope, I need to remove the infrastructure
Do not use a CDN, this violates GDPR rules
Maybe remove them in a separate PR and we will see |
But jsDelivr is GDPR compliant, isn't it? When we collect, use, and process personal data, we are subject to the provisions of the UK General Data Protection Regulation (UK GDPR) and the Data Protection Act 2018. We are also subject to the EU General Data Protection Regulation (EU GDPR) in relation to personal data we collect, use, and process in the European Economic Area (EEA). https://www.jsdelivr.com/terms/privacy-policy And Bootstrap recommends it itself. https://getbootstrap.com/docs/5.3/getting-started/introduction/ Anyway, I've made some more changes to the website. Does it look okay so far? There are still a few pages missing, but then I'll open the PR. The team page now uses GitHub avatars, I hope that's ok! |
No provider will be, please host the assets in our website :) "They’re just not useful to serve static dependencies off-site in hopes of users hitting a primed cache from another site, because of cache partitioning"
The changes look great ! PS: You can do a previous members section and move "Dan" to it.
Well, I guess we can keep it as it is for now. But maybe it would be better to host them. |
robots is a "standard" meta tag: https://robots-txt.com/meta-robots/ |
Understood. I'm not going to use a CDN and have added the robots tag back. I'm opening a few PRs now, and I've noticed that the checks don't pass. Could you take a look at this? Seems like I once mentioned in another PR (see here) that a migration is missing. |
I also just noticed that the Codacy badge in the README doesn't load, and the website only returns 404 🤔 |
I did login to Codacy, the setup was not approved nor done. I will remove it: I need test commits as I try to fix our mailing list hook ^^ |
Ready for the next PR to try the spam new check ^^ |
I'm currently preparing everything for the PR for the layout update. I can't do several PRs for this because everything is interdependent. While I'm at it, I also refreshed the 404 page: And the news on the home page: But I could do the PR for the unused files I was talking about. |
Let's do a list of items and keep this one for the end maybe |
I had the motivation to refresh the phpMyAdmin website a bit, i.e. update Bootstrap, add darkmode and improve the design a bit. Not a complete redesign, but just nice little changes.
These are some of the things I've done so far:
What I want to do before the PR comes:
What I would suggest:
Finally, some screenshots:
Home page
Current:
Download modal
Current:
Footer
I have seen that the current website should have an email icon in the footer, but it is not displayed due to missing CSS. So "Contact" just sends an email to "developers@phpmyadmin.net". The footer is always placed at the bottom.
Current: (I know, Twitter was better)
I look forward to your feedback and hope that you would like such a PR, at least I think that the phpMyAdmin website definitely needs a darkmode.
The text was updated successfully, but these errors were encountered: