Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurring Google instances are being treated as exceptions #2034

Open
phw198 opened this issue Jan 2, 2025 · 3 comments
Open

Recurring Google instances are being treated as exceptions #2034

phw198 opened this issue Jan 2, 2025 · 3 comments
Assignees
Labels
bug Something's not working right recurring appointment waiting fix confirmation Hotfix available for testing

Comments

@phw198
Copy link
Owner

phw198 commented Jan 2, 2025

v2.11.1

As reported by #1796 #1983 #2024.

When syncing an Outlook recurring series with exceptions, OGCS can retrieve all the recurring instances in order to identify which one needs updating to make it a matching exception. However, when it does this, it adds all the instances to the cached exceptions - this then severely affects performance for series that contain many instances (eg daily recurring for several years). It also is not restricting the instances to just the date range being synced.

@phw198 phw198 added bug Something's not working right recurring appointment labels Jan 2, 2025
@phw198 phw198 self-assigned this Jan 2, 2025
phw198 added a commit that referenced this issue Jan 2, 2025
…exceptions.

Always SeparateGoogleExceptions() at the end before returning.
#2034
@phw198
Copy link
Owner Author

phw198 commented Jan 2, 2025

📦 This should now be resolved with hotfix v2.11.1.2.zip (see instructions for applying).
      CRCs: Zip = 6525FBCB Exe = 605966C1

@mayonezo @HenrikJanPersson @mjlipton
If you are still encountering slow sync and log entries with something like This is a recurring Google event with <100s> exceptions in the sync date range, please let me know how it goes with this hotfix.

@phw198 phw198 added the waiting fix confirmation Hotfix available for testing label Jan 2, 2025
@HenrikJanPersson
Copy link

Thanks @phw198 The sync went so much faster for me now. I will let you know if I notice any other changes. Again, your efforts are much appreciated!

@mayonezo
Copy link

mayonezo commented Jan 7, 2025

I don't see the exact same issue anymore, because the faulty event was replaced. I do still have similar events in my calendar, though. I did get issues with those in the past, so might be worth a try.

First sync with the hotfix applied seems to have finished successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working right recurring appointment waiting fix confirmation Hotfix available for testing
Projects
None yet
Development

No branches or pull requests

3 participants