Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: mailpit container_name docker-compose.yaml #587

Closed
derhecht opened this issue Jul 3, 2024 · 2 comments · Fixed by #589
Closed

[Improvement]: mailpit container_name docker-compose.yaml #587

derhecht opened this issue Jul 3, 2024 · 2 comments · Fixed by #589
Labels
Milestone

Comments

@derhecht
Copy link

derhecht commented Jul 3, 2024

Improvement description

Every container which is starting up by docker compose command will generate a custom name based on folder/project name. Expect the mailpit container.
This will conflict e.g. if you running multiple instances of pimcore on one machine or have an already standalone instance of mailpit running.

Improvement: Remove container_name directive from docker-compose.yaml file.

The mailpit service is referenced by its service name which is mailpit - for every setup - not by its container name.

@blankse
Copy link
Contributor

blankse commented Jul 3, 2024

@derhecht I created a PR: #589

@alexz707 alexz707 added Bug and removed Improvement labels Jul 4, 2024
@alexz707 alexz707 added this to the 2024.2.1 milestone Jul 4, 2024
@alexz707
Copy link
Contributor

alexz707 commented Jul 4, 2024

Thanks for bringing that up and thanks for the PR, already merged

@alexz707 alexz707 closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants