From 402ce518cb236955ad359a5d27a69f1881c2e6d4 Mon Sep 17 00:00:00 2001
From: mattamon <matthias.schuhmayer@pimcore.com>
Date: Mon, 13 May 2024 12:15:11 +0200
Subject: [PATCH] Remove additional hydrator service

---
 config/properties.yaml                        |  3 -
 .../Service/PropertyHydratorService.php       | 71 -------------------
 .../PropertyHydratorServiceInterface.php      | 33 ---------
 3 files changed, 107 deletions(-)
 delete mode 100644 src/Property/Service/PropertyHydratorService.php
 delete mode 100644 src/Property/Service/PropertyHydratorServiceInterface.php

diff --git a/config/properties.yaml b/config/properties.yaml
index 83a49268d..f178e3c94 100644
--- a/config/properties.yaml
+++ b/config/properties.yaml
@@ -15,9 +15,6 @@ services:
   Pimcore\Bundle\StudioBackendBundle\Property\RepositoryInterface:
     class: Pimcore\Bundle\StudioBackendBundle\Property\Repository
 
-  Pimcore\Bundle\StudioBackendBundle\Property\Service\PropertyHydratorServiceInterface:
-    class: Pimcore\Bundle\StudioBackendBundle\Property\Service\PropertyHydratorService
-
   Pimcore\Bundle\StudioBackendBundle\Property\Service\PropertyServiceInterface:
     class: Pimcore\Bundle\StudioBackendBundle\Property\Service\PropertyService
 
diff --git a/src/Property/Service/PropertyHydratorService.php b/src/Property/Service/PropertyHydratorService.php
deleted file mode 100644
index 0d8cda795..000000000
--- a/src/Property/Service/PropertyHydratorService.php
+++ /dev/null
@@ -1,71 +0,0 @@
-<?php
-declare(strict_types=1);
-
-/**
- * Pimcore
- *
- * This source file is available under two different licenses:
- * - GNU General Public License version 3 (GPLv3)
- * - Pimcore Commercial License (PCL)
- * Full copyright and license information is available in
- * LICENSE.md which is distributed with this source code.
- *
- *  @copyright  Copyright (c) Pimcore GmbH (http://www.pimcore.org)
- *  @license    http://www.pimcore.org/license     GPLv3 and PCL
- */
-
-namespace Pimcore\Bundle\StudioBackendBundle\Property\Service;
-
-use Pimcore\Bundle\StaticResolverBundle\Models\Element\ServiceResolver;
-use Pimcore\Bundle\StudioBackendBundle\Property\Hydrator\ElementPropertyHydratorInterface;
-use Pimcore\Bundle\StudioBackendBundle\Property\Hydrator\PropertyHydratorInterface;
-use Pimcore\Bundle\StudioBackendBundle\Property\RepositoryInterface;
-use Pimcore\Bundle\StudioBackendBundle\Property\Request\PropertiesParameters;
-use Pimcore\Bundle\StudioBackendBundle\Property\Schema\PredefinedProperty;
-use Pimcore\Bundle\StudioBackendBundle\Util\Traits\ElementProviderTrait;
-use Pimcore\Model\Property\Predefined;
-
-final readonly class PropertyHydratorService implements PropertyHydratorServiceInterface
-{
-    use ElementProviderTrait;
-
-    public function __construct(
-        private RepositoryInterface              $repository,
-        private ServiceResolver                  $serviceResolver,
-        private ElementPropertyHydratorInterface $dataPropertyHydrator,
-        private PropertyHydratorInterface        $predefinedPropertyHydrator,
-    ) {
-    }
-
-    /**
-     * @return PredefinedProperty[]
-     */
-    public function getHydratedProperties(PropertiesParameters $parameters): array
-    {
-        $properties = $this->repository->listProperties($parameters);
-        $hydratedProperties = [];
-        foreach ($properties->load() as $property) {
-            $hydratedProperties[] = $this->predefinedPropertyHydrator->hydrate($property);
-        }
-
-        return $hydratedProperties;
-    }
-
-    public function getHydratedPropertyForElement(string $elementType, int $id): array
-    {
-        $element = $this->getElement($this->serviceResolver, $elementType, $id);
-
-        $hydratedProperties = [];
-
-        foreach($element->getProperties() as $property) {
-            $hydratedProperties[] = $this->dataPropertyHydrator->hydrate($property);
-        }
-
-        return ['items' => $hydratedProperties];
-    }
-
-    public function getHydratedPredefinedProperty(Predefined $predefined): PredefinedProperty
-    {
-        return $this->predefinedPropertyHydrator->hydrate($predefined);
-    }
-}
diff --git a/src/Property/Service/PropertyHydratorServiceInterface.php b/src/Property/Service/PropertyHydratorServiceInterface.php
deleted file mode 100644
index 1bc0a345f..000000000
--- a/src/Property/Service/PropertyHydratorServiceInterface.php
+++ /dev/null
@@ -1,33 +0,0 @@
-<?php
-declare(strict_types=1);
-
-/**
- * Pimcore
- *
- * This source file is available under two different licenses:
- * - GNU General Public License version 3 (GPLv3)
- * - Pimcore Commercial License (PCL)
- * Full copyright and license information is available in
- * LICENSE.md which is distributed with this source code.
- *
- *  @copyright  Copyright (c) Pimcore GmbH (http://www.pimcore.org)
- *  @license    http://www.pimcore.org/license     GPLv3 and PCL
- */
-
-namespace Pimcore\Bundle\StudioBackendBundle\Property\Service;
-
-use Pimcore\Bundle\StudioBackendBundle\Property\Request\PropertiesParameters;
-use Pimcore\Bundle\StudioBackendBundle\Property\Schema\PredefinedProperty;
-use Pimcore\Model\Property\Predefined;
-
-interface PropertyHydratorServiceInterface
-{
-    /**
-     * @return PredefinedProperty[]
-     */
-    public function getHydratedProperties(PropertiesParameters $parameters): array;
-
-    public function getHydratedPropertyForElement(string $elementType, int $id): array;
-
-    public function getHydratedPredefinedProperty(Predefined $predefined): PredefinedProperty;
-}