Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please Exclude the clips page. #121

Open
TsukiZero opened this issue Dec 2, 2022 · 5 comments
Open

Please Exclude the clips page. #121

TsukiZero opened this issue Dec 2, 2022 · 5 comments

Comments

@TsukiZero
Copy link

It seems to add unnecessary load padding to it when trying to make clips and sometimes doesn't make the clip snipping work as it should.

Also refer to this: Tampermonkey/tampermonkey#1667

@pixeltris
Copy link
Owner

PRs are welcome. It's unlikely I'll ever look at this as I don't have an account.

@TsukiZero
Copy link
Author

what I meant is basically add @exclude *://clips.twitch.tv/* and @noframes to the script. It's all

@pixeltris
Copy link
Owner

I'm not so sure about adding @noframes as if I'm understanding it that would make the script no longer functional on sites which embed the player.

@TsukiZero
Copy link
Author

TsukiZero commented Dec 4, 2022

If I had a site to test that, I would...

OK, it's as you say, Embeds will not work with it...

@TsukiZero
Copy link
Author

TsukiZero commented Dec 4, 2022

As is, the script sometimes breaks clips creation (causes the clip creation page's player to refresh, and in turn the trimmer doesn't work as intended and only the initial trim setup is used behind the scenes), and also runs multiple times per page (3 times), delaying things some.

Perhaps it might be possible to add a check for the page and iframes involved to see if it needs to run in those pages or frames. If JS were as simple as Action Script...

EDIT: Seems the solution is actually simpler for most things:

// @exclude      *://clips.twitch.tv/*
// @exclude      *://passport.twitch.tv/*
// @exclude      *://gql.twitch.tv/*
// @exclude      *://*.twitch.tv/p/ffz_bridge/

The last item is because this is a thing exclusive to Clips page and its interaction with FFZ (which, surprise surprise, happens in an iframe).

So doing this prevents the script from running on the Clips page entirely.

Another possibility (didn't test this one) is change @match to:

// @match        *://www.twitch.tv/*
// @match        *://player.twitch.tv/*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants