Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please exclude VODS from the ublock origin script. #251

Open
chrcoluk opened this issue May 15, 2024 · 3 comments
Open

Please exclude VODS from the ublock origin script. #251

chrcoluk opened this issue May 15, 2024 · 3 comments

Comments

@chrcoluk
Copy link

When watching VODs on twitch the script causes the page to hang in firefox, I have to forcefully kill the tab.

I have attempted to try and alter the ublock rule, but I dont know ad block syntax and was told on reddit its not possible, but instead to come here and ask for the script to be changed to not process on VODS.

VODs load from the /videos/ url.

@pixeltris
Copy link
Owner

I can't reproduce this issue under firefox. Looking at the code and comparing it to the m3u8 requests I don't see anything that would negatively impact /videos/ urls. Closing for now. An example VOD url where this occurs would be useful.

@chrcoluk
Copy link
Author

I think it gets triggered when audio is mooted due to copyright and it mistakes it as an advert.

Essentially when the issue happens I see in the corner it is blocking ad's but VOD's dont have ad's so exempting even if you cant reproduce it shouldnt be a problem.

@pixeltris
Copy link
Owner

Essentially when the issue happens I see in the corner it is blocking ad's but VOD's dont have ad

I think that happens when you're on a stream and an ad plays then you click through to vods. The url changes but the page is still the same so even if /videos/ was filtered out the script would stay loaded. But I'll take a look and see if the script is doing anything crazy in that scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants