-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ads with video-swap-new v1.29 on firefox when opening in background tab #277
Comments
@pixeltris Noting this here since it's related to the new commits. Getting some playback issues with both vaft and video-swap new userscripts that didn't happen prior to the new commits. Using Firefox 127.0.2 with ViolentMonkey. Midroll screens are either black or stuck on a frozen frame. Once midrolls are over i do see |
This all might belong in #226 instead. Am seeing this message in console that is maybe vaft related. Strange I can reliably get the freezing issue with the updated commit despite vaft being mostly issue free previously for me. |
Fixed in 0863c6d @stevenya97 that's pretty strange as nothing changed in terms of what the script does other than checking if another script is already active. But yea, playback problems belong in the already open issues. FYI VAFT under Firefox has been unusable for me for some time as it always freezes for me. Someone mentioned of a possible fix a while back I just haven't looked into it yet |
The latency thing is weird, it's mentioned here #119 (comment). My guess is the player uses some value in the m3u8 file to track latency and when the swap happens that value is way different than in the original m3u8 so the latency value mess up |
Yeah that was my guess as well, though it is strange that vaft is not affected. I understood it as the m3u8 swapping method is different between scripts but the m3u8 itself they fetch are the same? Must be different enough in some way to throw off whatever internal heuristic the player uses for it. |
The major difference is video-swap-new reloads the player when it changes the active m3u8, so it could be related to that |
when opening a stream in a background tab ads will play when you switch to that tab
i've rolled back to version 1.28 and ads no longer get through
edit: using the userscript version with violentmonkey
The text was updated successfully, but these errors were encountered: