Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ads with video-swap-new v1.29 on firefox when opening in background tab #277

Closed
yvawt opened this issue Aug 20, 2024 · 8 comments
Closed

Comments

@yvawt
Copy link

yvawt commented Aug 20, 2024

when opening a stream in a background tab ads will play when you switch to that tab
i've rolled back to version 1.28 and ads no longer get through
edit: using the userscript version with violentmonkey

@stevenya97
Copy link

stevenya97 commented Aug 21, 2024

@pixeltris Noting this here since it's related to the new commits. Getting some playback issues with both vaft and video-swap new userscripts that didn't happen prior to the new commits. Using Firefox 127.0.2 with ViolentMonkey.

Midroll screens are either black or stuck on a frozen frame. Once midrolls are over i do see Finished blocking ads message and the stream plays again. Observed mostly with vaft but will report back if I see this with video-swap-new (Edit: ad stream appears to play fine on video-swap-new).
Screenshot 2024-08-21 131019
Screenshot 2024-08-21 130330
Screenshot 2024-08-21 130313

@stevenya97
Copy link

stevenya97 commented Aug 21, 2024

Hmm, tried vaft userscript in another browser(Safari on macOS) and midrolls switched with no issue and got this output.
Screenshot 2024-08-21 at 2 31 21 PM

More console messages with video-swap-new despite there not being any playback issues.
Screenshot 2024-08-21 143516

I also seem to be getting ALOT more midrolls, almost every 5 minutes but that could be on Twitch's end and not related to the scripts. Will keep monitoring.

@stevenya97
Copy link

stevenya97 commented Aug 21, 2024

This all might belong in #226 instead. Am seeing this message in console that is maybe vaft related.
Screenshot 2024-08-21 145038
Screenshot 2024-08-21 145854

Strange I can reliably get the freezing issue with the updated commit despite vaft being mostly issue free previously for me.

@pixeltris
Copy link
Owner

pixeltris commented Aug 21, 2024

Fixed in 0863c6d

@stevenya97 that's pretty strange as nothing changed in terms of what the script does other than checking if another script is already active. But yea, playback problems belong in the already open issues. FYI VAFT under Firefox has been unusable for me for some time as it always freezes for me. Someone mentioned of a possible fix a while back I just haven't looked into it yet

@stevenya97
Copy link

stevenya97 commented Aug 21, 2024

Gotcha👍🏻 Yeah I've always recommended video-swap-new to other users here as it tends to have less issues than vaft, but it was indeed strange as I try to test vaft after any new commits and haven't had this many freezes before. No worries as video-swap-new works in the meantime.

On the side, is there a solution to the reported stream latency to broadcaster stat? It always reports a negative value in video-swap-new while vaft seems to get a proper value. Is this a known limitation?
Screenshot 2024-08-21 172947

@pixeltris
Copy link
Owner

The latency thing is weird, it's mentioned here #119 (comment). My guess is the player uses some value in the m3u8 file to track latency and when the swap happens that value is way different than in the original m3u8 so the latency value mess up

@stevenya97
Copy link

Yeah that was my guess as well, though it is strange that vaft is not affected. I understood it as the m3u8 swapping method is different between scripts but the m3u8 itself they fetch are the same? Must be different enough in some way to throw off whatever internal heuristic the player uses for it.

@pixeltris
Copy link
Owner

The major difference is video-swap-new reloads the player when it changes the active m3u8, so it could be related to that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants