Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrobbling of tracks not possible #1

Open
mark-me opened this issue Feb 28, 2024 · 3 comments
Open

Scrobbling of tracks not possible #1

mark-me opened this issue Feb 28, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@mark-me
Copy link

mark-me commented Feb 28, 2024

First off: thank you for this wonderful package: very happy to have found it. Am I correct in thinking the TrackScrobble class doesn't have the params necessary to do a scrobble? I'd be happy to help out.

@pkeorley
Copy link
Owner

Thank you very much! Thank you for the nice wishes! 😁

The problem with the TrackScrobble class is my inattention, the problem was that I accidentally missed implementing parameters and writing documentation for this class.

Therefore, in the new updated version and all subsequent versions (i.e. >=1.2.2) there is already a patch that solves this problem, BUT I'm not quite sure if it works, since I tried to figure out this particular method for an hour and a half, but I failed

In general, there are plans to release version 2.0.0, where the API and the amount of code is much smaller and lighter, but it's far from being done because the work is not yet complete

@pkeorley pkeorley added the bug Something isn't working label Feb 29, 2024
@mark-me
Copy link
Author

mark-me commented Feb 29, 2024

Thank you for the fast reply. I've upgraded the package and as you mentioned, the parameters are in place. When I have some time I will test and let you know what works or doesn't. Preliminary testing showed it didn't work, but I do not exclude it being an issue with my code... I will research and let you know.

Looking forward to version 2.0.0 and I will gladly help you test.

@pkeorley
Copy link
Owner

pkeorley commented Mar 1, 2024

Thank you for your sincere wishes! It encourages me to keep working on the library. 😁

Most likely, the problem lies in my clumsy code that I added to version 1.2.2

If you manage to understand how the lastfmxpy library works, you will most likely be able to fix this misunderstanding and use this library fully, but today I see many bugs that could be fixed in version 2.0.0, which I do not have the strength to take on yet, I am too inexperienced in writing clean and good code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants