Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPS: Duplicate Galley Views Countes #10082

Closed
bozana opened this issue Jun 18, 2024 · 2 comments
Closed

OPS: Duplicate Galley Views Countes #10082

bozana opened this issue Jun 18, 2024 · 2 comments
Assignees
@bozana
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone
3.3.0-18

Comments

@bozana
Copy link
Collaborator

bozana commented Jun 18, 2024 •
edited
Loading

s. https://forum.pkp.sfu.ca/t/duplicate-galley-view-counts/88363

When creating a new version of a preprint (and article) a new galley is created that points to/contains the same file ID as the previous galley. This function getTotalGalleyViews (s. https://github.com/pkp/ops/blob/stable-3_3_0/classes/submission/Submission.inc.php#L251) does not consider it however, which leads to wrong vies numbers.

PRs:
stable-3_3_0: pkp/ops#708
stable-3_4_0: pkp/ops#709
main: pkp/ops#710
@bozana bozana added this to the 3.3.0-18 milestone Jun 18, 2024
@bozana bozana added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Jun 18, 2024
bozana added a commit to bozana/ops that referenced this issue Jun 18, 2024
@bozana
pkp/pkp-lib#10082 Fix getTotalGalleyViews()
bb80701
@bozana bozana mentioned this issue Jun 18, 2024
Merged
bozana added a commit to bozana/ops that referenced this issue Jun 18, 2024
@bozana
pkp/pkp-lib#10082 consider same file IDs in getTotalGalleyViews()
f558532
@bozana bozana mentioned this issue Jun 18, 2024
Merged
bozana added a commit to bozana/ops that referenced this issue Jun 18, 2024
@bozana
pkp/pkp-lib#10082 consider same file IDs in getTotalGalleyViews()
f7dda45
@bozana bozana mentioned this issue Jun 18, 2024
Merged
@bozana
Copy link
Collaborator Author

bozana commented Jun 18, 2024 •
edited
Loading

@jonasraoni, could you please take a look at the PRs above?
Thanks a lot!

@bozana bozana self-assigned this Jun 18, 2024
bozana added a commit to pkp/ops that referenced this issue Jun 19, 2024
@bozana
Merge pull request #708 from bozana/10082
3eaee33 
pkp/pkp-lib#10082 Fix getTotalGalleyViews()
bozana added a commit to pkp/ops that referenced this issue Jun 19, 2024
@bozana
Merge pull request #710 from bozana/10082-main
86abeec 
pkp/pkp-lib#10082 consider same file IDs in getTotalGalleyViews()
bozana added a commit to pkp/ops that referenced this issue Jun 19, 2024
@bozana
Merge pull request #709 from bozana/10082-3_4_0
f58b9f8 
pkp/pkp-lib#10082 consider same file IDs in getTotalGalleyViews()
@bozana
Copy link
Collaborator Author

bozana commented Jun 19, 2024

Thanks a lot @jonasraoni!

@bozana bozana closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bozana bozana

Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Milestone
3.3.0-18
Development

No branches or pull requests
1 participant
@bozana