Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Planning as a Service solver and planimition plugin #19

Open
nirlipo opened this issue Mar 13, 2024 · 0 comments
Open

[Bug]: Planning as a Service solver and planimition plugin #19

nirlipo opened this issue Mar 13, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@nirlipo
Copy link
Contributor

nirlipo commented Mar 13, 2024

Contact Details

nirlipo@gmail.com

What happened?

The new solver online needs to be integrated with the planimation plugin currently in the editor. We need to test if the same issue occurs when using planimation outside of the editor online:

https://planimation.planning.domains/

This is the info about the new solver: 

https://nirlipo.github.io/project/paas/

and the plugin for the solver is here:

https://github.com/AI-Planning/planning-as-a-service-plugin

whereas the one for  planimation:

https://github.com/planimation/plugins/tree/master/editor.domains

The main change needed is to update the URL for the solver to be by default https (before it didn't have SSL). And, you need to select one of the available installed packages (solvers)

https://solver.planning.domains:5001/package

and if you want to use one of the packages, then the API to use a solver would be for example:

https://solver.planning.domains:5001/package/dual-bfws-ffparser/solve

You may need to update the plugin to reflect this change. Ideally the new default solver would be the link above.

I may miss some aspect in terms of how to trigger the call, and how the backend processes the response from the planner. There may be a change needed there too.

Session

https://tinyurl.com/yxlt96fp

Reproduce the bug

Try to planimate. The custom url is pointing to the legacy solver. We need to update to use the new solver instead of the solve plugin.

Expected behaviour

No planimation should appear. Alternatively one can call the solver, generate a plan, download it, upload it to the editor, and then use the planimation plugin using the plan. But, we want to fix this and be able to use the new solver online.

Relevant log output

N/A
@nirlipo nirlipo added the bug Something isn't working label Mar 13, 2024
@nirlipo nirlipo added the good first issue Good for newcomers label Mar 13, 2024
@nirlipo nirlipo moved this from Triage to Todo in Planimation Overview Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Development

No branches or pull requests

1 participant