Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gamedao-protocol according to M2 review #192

Open
21 of 23 tasks
vayesy opened this issue Oct 27, 2022 · 0 comments · Fixed by gamedaoco/gamedao-protocol#115
Open
21 of 23 tasks

Update gamedao-protocol according to M2 review #192

vayesy opened this issue Oct 27, 2022 · 0 comments · Fixed by gamedaoco/gamedao-protocol#115
Assignees
Labels

Comments

@vayesy
Copy link
Member

vayesy commented Oct 27, 2022

What needs to be done

Update code to fix issues, noted during Milestone 2 code review from Parity team.

Why it needs to be done

Increase code quality, follow best practices and high standards of the industry.

Acceptance Criteria/Task List

Fix next code issues

Control

  • for genesis build block number should be known [source]
  • new function for types::Org [source]
  • print some logs if sth goes wrong while genesis build [source]
  • use is_some to check for set values [source]
  • update pay_membership_fee method to accept org and use it's fields [source]
  • replace unwrap with error handling [source]
  • move event creating from helper to extrinsic [source]
  • move event creating from helper to extrinsic [source]
  • move benchmarking trait to benchmarks module [source]

Flow

  • cleanup storage if campaign doesn't exist [souce]
  • replace unwrap with error handling [source]
  • replace if, else if with match clause [source]
  • replace if, else if with match clause [source]
  • move benchmarking trait to benchmarks module [source]

Sense

  • replace unwrap with error handling [source]

Signal

  • replace unwrap with error handling [source]
  • replace unwrap with error handling [source]
  • replace unwrap with error handling [source]
  • ensure proposal finalization properly handled [source]
  • replace unwrap with error handling [source]
  • proper error handling for currency call [source]
  • proper error handling for currency call [source]
  • self-explanatory tests names [source]

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants