Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zero-network according to M2 review #193

Open
6 tasks done
vayesy opened this issue Oct 28, 2022 · 0 comments · Fixed by #197
Open
6 tasks done

Update zero-network according to M2 review #193

vayesy opened this issue Oct 28, 2022 · 0 comments · Fixed by #197
Assignees
Labels

Comments

@vayesy
Copy link
Member

vayesy commented Oct 28, 2022

What needs to be done

Update code to fix issues, noted during Milestone 2 code review from Parity team.

Why it needs to be done

Increase code quality, follow best practices and high standards of the industry.

Acceptance Criteria/Task List

Fix next code issues

Runtime

  • use crate repository links instead of using submodule for ORML [source]

Primitives

  • use BoundedVec instead of Vec for fields in AssetMetadata struct [source]

Asset registry

  • don't include metadata in asset events [source]
  • log message in case of error during genesis build [source]
  • merge refactor_***_native_asset into one method [source]
  • split unit tests into single test case scenarios [source]

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants