Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnnotationStorage superfluous? #5

Open
jensens opened this issue May 12, 2015 · 3 comments
Open

AnnotationStorage superfluous? #5

jensens opened this issue May 12, 2015 · 3 comments

Comments

@jensens
Copy link
Member

jensens commented May 12, 2015

The complete implementation here is unused:
https://github.com/plone/plone.behavior/blob/master/plone/behavior/annotation.py

The only place ist used is a test case here.
https://github.com/plone/plone.app.versioningbehavior/blob/master/plone/app/versioningbehavior/tests/test_modifiers.py#L92

I propose to move annotation.[py|rst] to a testing [py|rst] - thats what its used for - and the whole code is less confusing afterwards.

@jensens
Copy link
Member Author

jensens commented May 12, 2015

Refine: With unused I meant outsite plone.behaviors own tests.

@jensens
Copy link
Member Author

jensens commented May 13, 2015

@jensens
Copy link
Member Author

jensens commented May 13, 2015

I would not recommend using this default storage. It blews up the number of objects in ZODB massively and will for sure make ZODB caching less efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant