-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alert users that depend on plotly-latest
that the website is using latest v1 not the latest
#3118
Comments
We could probably add a note to our documentation but I agree with Alex that in terms of how this should materialize in the product, we should issue a patch release on top of |
I don’t think it even needs a new release (in fact it should not be a new release, anyone using 1.x explicitly should see no change), just a new file uploaded to plotly-latest that adds a console warning to the existing file |
Only overwriting the CDN files may/will potentially break websites that load the source file using a hash for extra security. Please see https://content-security-policy.com/hash/ Instead IMHO we should release a plotly.js v1 patch to properly address this issue. |
But plotly-latest changed many times in the past and we never worried about the hash changing, why would it be different now? If you're using an unversioned file like plotly-latest you expect the file and its hash to change from time to time. Anyway if you really want to create a new release in the 1.x branch for this, how do we ensure that anyone loading that new release explicitly will not see this warning, only people loading plotly-latest will see it? |
Yeah I tend to agree with Alex -- in Python this would probably be issued as a I think it's fine not to issue a new release and to just add the warning straight to the CDN. |
@ndrezn What should the console warning contain exactly? |
Something along the lines of:
@LiamConnors do you have opinions on this? |
I like that message, though I'd tweak it a little. It's v1.58.5, which was released July 2021, but that's just a security patch. The latest feature release on the 1.x branch is from Dec 2020 but both are so old I'd stick with the actual 1.58.5 date. And I'd emphasize that despite the name it's no longer the latest. So something like:
|
plotly-latest
that the website is using latest v1 not the latest? And how?plotly-latest
that the website is using latest v1 not the latest
Originally posted by @alexcjohnson in #1794
The text was updated successfully, but these errors were encountered: