New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge POST /accounts/verify/:token into PATCH /accounts/:id #974

Open

lautarodragan opened this issue Jul 20, 2019 · 0 comments

Labels

Member

lautarodragan commented Jul 20, 2019 •

edited

Loading

It's just an update to the account after all.

The only special thing about it is the authorization - it requires a special token.

if (body.verified && tokenData.meta.name !== Token.VerifyAccount.meta.name) {
  logger.warn({ account, tokenData }, 'User tried to verify email with incorrect token type.')
  throw new Unauthorized()
}

It can be done in different steps to avoid breaking anything:

Add functionality to PATCH /accounts
Make changes in Explorer
Remove deprecated endpoint

lautarodragan added the refactor label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment